12 Nov, 2013
1 commit
-
Remove unused eb parameter from btrfs_item_nr
Signed-off-by: Ross Kirk
Reviewed-by: David Sterba
Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason
01 Sep, 2013
6 commits
-
struct __prelim_ref is allocated and freed frequently when
walking backref tree, using slab allocater can not only
speed up allocating but also detect memory leaks.Signed-off-by: Wang Shilong
Reviewed-by: Miao Xie
Reviewed-by: Jan Schmidt
Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
Currently, only add_delayed_refs have to allocate with GFP_ATOMIC,
So just pass arg 'gfp_t' to decide which allocation mode.Signed-off-by: Wang Shilong
Reviewed-by: Miao Xie
Reviewed-by: Jan Schmidt
Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
u64 is "unsigned long long" on all architectures now, so there's no need to
cast it when formatting it using the "ll" length modifier.Signed-off-by: Geert Uytterhoeven
Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
make C=2 fs/btrfs/ CF=-D__CHECK_ENDIAN__
I tried to filter out the warnings for which patches have already
been sent to the mailing list, pending for inclusion in btrfs-next.All these changes should be obviously safe.
Signed-off-by: Stefan Behrens
Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
Signed-off-by: Wang Shilong
Reviewed-by: Miao Xie
Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
Signed-off-by: Filipe David Borba Manana
Reviewed-by: Jan Schmidt
Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason
10 Aug, 2013
2 commits
-
Because we don't mess with the offset into the extent for compressed we will
properly find both extents for this case[extent a][extent b][rest of extent a]
but because we already added a ref for the front half we won't add the inode
information for the second half. This causes us to leak that memory and not
print out the other offset when we do logical-resolve. So fix this by calling
ulist_add_merge and then add our eie to the existing entry if there is one.
With this patch we get both offsets out of logical-resolve. With this and the
other 2 patches I've sent we now pass btrfs/276 on my vm with compress-force=lzo
set. Thanks,Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason -
If you do btrfs inspect-internal logical-resolve on a compressed extent that has
been partly overwritten it won't find anything. This is because we try and
match the extent offset we've searched for based on the extent offset in the
data extent entry. However this doesn't work for compressed extents because the
offsets are for the uncompressed size, not the compressed size. So instead only
do this check if we are not compressed, that way we can get an actual entry for
the physical offset rather than nothing for compressed. Thanks,Signed-off-by: Josef Bacik
Signed-off-by: Chris Mason
02 Jul, 2013
1 commit
-
I missed fixing the backref stuff when I introduced the skinny metadata. If you
try and do things like snapshot aware defrag with skinny metadata you are going
to see tons of warnings related to the backref count being less than 0. This is
because the delayed refs will be found for stuff just fine, but it won't find
the skinny metadata extent refs. With this patch I'm not seeing warnings
anymore. Thanks,Reviewed-by: Liu Bo
Signed-off-by: Josef Bacik
01 Jul, 2013
1 commit
-
Looking into this backref problem I noticed we're using a macro to what turns
out to essentially be a NULL check to see if we need to search the commit root.
I'm killing this, let's just do what everybody else does and checks if trans ==
NULL. I've also made it so we pass in the path to __resolve_indirect_refs which
will have the search_commit_root flag set properly already and that way we can
avoid allocating another path when we have a perfectly good one to use. Thanks,Signed-off-by: Josef Bacik
18 May, 2013
1 commit
-
In the find_parent_nodes(), if read_tree_block() fails, we can
not return directly, we should free some allocated memory otherwise
memory leak happens.Signed-off-by: Wang Shilong
Signed-off-by: Josef Bacik
07 May, 2013
8 commits
-
Big patch, but all it does is add statics to functions which
are in fact static, then remove the associated dead-code fallout.removed functions:
btrfs_iref_to_path()
__btrfs_lookup_delayed_deletion_item()
__btrfs_search_delayed_insertion_item()
__btrfs_search_delayed_deletion_item()
find_eb_for_page()
btrfs_find_block_group()
range_straddles_pages()
extent_range_uptodate()
btrfs_file_extent_length()
btrfs_scrub_cancel_devid()
btrfs_start_transaction_lflush()btrfs_print_tree() is left because it is used for debugging.
btrfs_start_transaction_lflush() and btrfs_reada_detach() are
left for symmetry.ulist.c functions are left, another patch will take care of those.
Signed-off-by: Eric Sandeen
Signed-off-by: Josef Bacik -
We kept leaking extent buffers when mounting a broken file system and it turns
out it's because not everybody uses read_tree_block properly. You need to check
and make sure the extent_buffer is uptodate before you use it. This patch fixes
everybody who calls read_tree_block directly to make sure they check that it is
uptodate and free it and return an error if it is not. With this we no longer
leak EB's when things go horribly wrong. Thanks,Signed-off-by: Josef Bacik
-
Signed-off-by: Wang Shilong
Signed-off-by: Josef Bacik -
If out of memory happens, we should return -ENOMEM directly to the caller
rather than continue the work.Signed-off-by: Wang Shilong
Signed-off-by: Josef Bacik -
__merge_refs() always return 0, it is unnecessary
for the caller to check the return value.Signed-off-by: Wang Shilong
Signed-off-by: Josef Bacik -
The only error return value of __add_prelim_ref() is -ENOMEM,
just return errors rather than trigger BUG_ON().Signed-off-by: Wang Shilong
Reviewed-by: David Sterba
Signed-off-by: Josef Bacik -
If btrfs_find_all_roots() fails, 'roots' has been freed or 'roots'
fails to allocate. We don't need to free it outside btrfs_find_all_roots()
again.Fix it.Signed-off-by: Wang Shilong
Signed-off-by: Josef Bacik -
The reason that BUG_ON() happens in these places is just
because of ENOMEM.We try ro return ENOMEM rather than trigger BUG_ON(), the
caller will abort the transaction thus avoiding the kernel panic.Signed-off-by: Wang Shilong
Reviewed-by: Miao Xie
Reviewed-by: Jan Schmidt
Signed-off-by: Josef Bacik
27 Feb, 2013
1 commit
-
When a subvolume is removed, we remove the root item from the root tree,
while the tree blocks and backrefs remain for a while. When backref walking
comes across one of those orphan tree blocks, it can find a backref for a
no longer existing root. This is all good, we only must tolerate
__resolve_indirect_ref returning an error and continue with the good refs
found.Reported-by: Alex Lyakas
Signed-off-by: Jan Schmidt
Signed-off-by: Josef Bacik
13 Dec, 2012
2 commits
-
When __merge_refs merges two refs, it is also needed to merge the
inode_list of both refs. Otherwise we have missed backrefs and memory
leaks. This happens for example if two inodes share an extent and
both lie in the same leaf and thus also have the same parent.Signed-off-by: Alexander Block
Reviewed-by: Jan Schmidt
Signed-off-by: Chris Mason -
Just use WARN_ON rather than an if containing only WARN_ON(1).
A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)//
@@
expression e;
@@
- if (e) WARN_ON(1);
+ WARN_ON(e);
//Signed-off-by: Julia Lawall
Reviewed-by: David Sterba
Signed-off-by: Chris Mason
26 Oct, 2012
3 commits
-
This adds support for the new extended inode refs to btrfs send.
Signed-off-by: Jan Schmidt
-
To see the problem, create many hardlinks to the same file (120 should do it),
then look up paths by inode with:ls -i
btrfs inspect inode-resolve -v $ino /mnt/btrfsI noticed the memory layout of the fspath->val data had some irregularities
(some unnecessary gaps that stop appearing about halfway),
so I'm not sure there aren't any bugs left in it.
24 Oct, 2012
1 commit
-
In btrfs_find_all_roots' termination condition, we compare the level of the
old buffer we got from btrfs_search_old_slot to the level of the current
root node. We'd better compare it to the level of the rewinded root node.Signed-off-by: Jan Schmidt
09 Oct, 2012
2 commits
-
The iterate_irefs in backref.c is used to build path components from inode
refs. This patch adds code to iterate extended refs as well.I had modify the callback function signature to abstract out some of the
differences between ref structures. iref_to_path() also needed similar
changes.Signed-off-by: Mark Fasheh
-
This patch adds basic support for extended inode refs. This includes support
for link and unlink of the refs, which basically gets us support for rename
as well.Inode creation does not need changing - extended refs are only added after
the ref array is full.Signed-off-by: Mark Fasheh
02 Oct, 2012
4 commits
-
This is the change of the kernel side.
Translation of logical to inode used to have an upper limit 4k on
inode container's size, but the limit is not large enough for a data
with a great many of refs, so when resolving logical address,
we can end up with
"ioctl ret=0, bytes_left=0, bytes_missing=19944, cnt=510, missed=2493"This changes to regard 64k as the upper limit and use vmalloc instead of
kmalloc to get memory more easily.Signed-off-by: Josef Bacik
Signed-off-by: Liu Bo -
In logical resolve, we parse extent_from_logical()'s 'ret' as a kind of flag.
It is possible to lose our errors because
(-EXXXX & BTRFS_EXTENT_FLAG_TREE_BLOCK) is true.I'm not sure if it is on purpose, it just looks too hacky if it is.
I'd rather use a real flag and a 'ret' to catch errors.Acked-by: Jan Schmidt
Signed-off-by: Liu Bo -
Signed-off-by: Jan Schmidt
Signed-off-by: Chris Mason -
Btrfs send/receive uses the aux field to store inode numbers. On
32 bit machines this may become a problem.Also fix all users of ulist_add and ulist_add_merged.
Reported-by: Arne Jansen
Signed-off-by: Alexander Block
29 Aug, 2012
1 commit
-
In iterate_inodes_from_logical() the error result from
extent_from_logical() is patched by mistake. Typically ENOENT is
patched to EINVAL because (-ENOENT & BTRFS_EXTENT_FLAG_TREE_BLOCK)
evaluates to true.Signed-off-by: Stefan Behrens
26 Jul, 2012
2 commits
-
This is the kernel portion of btrfs send/receive
Conflicts:
fs/btrfs/Makefile
fs/btrfs/backref.h
fs/btrfs/ctree.c
fs/btrfs/ioctl.c
fs/btrfs/ioctl.hSigned-off-by: Chris Mason
-
Make iref_to_path non static (needed in send) and rename
it to btrfs_iref_to_pathSigned-off-by: Alexander Block
10 Jul, 2012
1 commit
-
We've got two mechanisms both required for reliable backref resolving (tree
mod log and holding back delayed refs). You cannot make use of one without
the other. So instead of requiring the user of this mechanism to setup both
correctly, we join them into a single interface.Additionally, we stop inserting non-blockers into fs_info->tree_mod_seq_list
as we did before, which was of no value.Signed-off-by: Jan Schmidt
27 Jun, 2012
2 commits
-
When delayed refs exist, btrfs_find_all_roots used to hold the delayed ref
mutex way longer than actually required. We ought to drop it immediately
after we're done collecting all the delayed refs.Signed-off-by: Jan Schmidt
-
With the tree mod log, we can have a tree that's two levels high, but
btrfs_search_old_slot may still return a path with the tree root at level
one instead. __resolve_indirect_ref must care for this and accept parents in
a lower level than expected.Signed-off-by: Jan Schmidt
21 Jun, 2012
1 commit
-
add_all_parents did assume that path is already at a correct extent data
item, which may not be true in case of data extents that were partly
rewritten and splitted.We need to check if we're on a matching extent for every item and only
for the ones after the first. The loop is changed to do this now.This patch also fixes a bug introduced with commit 3b127fd8 "Btrfs:
remove obsolete btrfs_next_leaf call from __resolve_indirect_ref".
The removal of next_leaf did sometimes result in slot==nritems when
the above described case happens, and thus resulting in invalid values
(e.g. wanted_obejctid) in add_all_parents (leading to missed backrefs
or even crashes).Signed-off-by: Alexander Block
Signed-off-by: Jan Schmidt
Signed-off-by: Chris Mason