25 Jun, 2013
1 commit
-
"ci13xxx" is bad for at least the following reasons:
* people often mistype it
* it doesn't add any informational value to the names it's used in
* it needlessly attracts mail filtersThis patch replaces it with "ci_hdrc", "ci_udc" or "ci_hw", depending
on the situation. Modules with ci13xxx prefix are also renamed accordingly
and aliases are added for compatibility. Otherwise, no functional changes.Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
18 Jun, 2013
4 commits
-
Even if a chipidea core is otg capable the board may not be. This allows
to explicitly set the core to host/peripheral mode. Without these flags
the driver falls back to the old behaviour.Signed-off-by: Sascha Hauer
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
This patch makes it possible to configure the PTW, PTS and STS bits
inside the portsc register for host and device mode before the driver
starts and the phy can be addressed as hardware implementation is
designed.Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Sascha Hauer
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
This patch removes the restriction of having a limited amount of only
four active tds on one endpoint. We use the linked list implementation
to manage all tds which get added and removed by hardware_{en,de}queue.The removal of this restriction adds the driver to run into a hardware
errata. It's possible that the hardware will still address an transfer
descriptor that already got cleaned up. To solve this the patch also
postpone the cleanup of processed tds by one.Signed-off-by: Michael Grzeschik
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
This patch adds iso endpoint support to the device controller.
It makes use of the multiplication bits in the maxpacket field
of the endpoint and calculates the multiplier bits for each
transfer description on every request.Signed-off-by: Michael Grzeschik
Reviewed-by: Peter Chen
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
12 Jun, 2013
1 commit
-
Re-enable chipidea irq even if there's no role changing to do. This is
a problem since b183c19f ("USB: chipidea: re-order irq handling to avoid
unhandled irqs"); when it manifests, chipidea irq gets disabled for good.Cc: stable@vger.kernel.org # v3.7
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
18 May, 2013
1 commit
-
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.Signed-off-by: Wolfram Sang
Acked-by: Alexander Shishkin
30 Mar, 2013
6 commits
-
Convert between big-endian and little-endian format when accessing the usb
controller structures which are little-endian by specification.
Fix cases where the little-endian memory layout is taken for granted.
The patch doesn't have any effect on the already supported little-endian
architectures.Signed-off-by: Svetoslav Neykov
[Alex: minor cosmetic fixes]
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
chipidea's ffs_nr() is pretty much what __ffs() does.
Use that one instead.
Signed-off-by: Felipe Balbi
[rebased on top of debug infrastructure rework]
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
Create and remove debugfs entries in hdrc probe/remove instead of
start/stop of the device controller. Gadget specific will not export
anything while the controller is in host mode.Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
Manual role switching function is there for debugging purposes, so has
to move to debugfs.Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
switch over to the newly added devm_ioremap_resource
which provides more consistent error messages.Signed-off-by: Felipe Balbi
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
Some headers included in the chipidea controller core are not needed,
remove them.Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
22 Jan, 2013
1 commit
-
Delete successive tests to the same location. In this case res has already
been tested for being NULL, and calling devm_request_and_ioremap will not
make it NULL. On the other hand, devm_request_and_ioremap can return NULL
on failure.A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@s exists@
local idexpression y;
expression x,e;
@@*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
//Signed-off-by: Julia Lawall
Cc: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
27 Nov, 2012
1 commit
-
The pointer to a platform_device struct must not be dereferenced after
the device has been unregistered.This bug produces a crash when unloading the ci13xxx kernel module
compiled with CONFIG_PAGE_POISONING enabled.Signed-off-by: Lothar Waßmann
Cc: stable # 3.6
Acked-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
22 Nov, 2012
3 commits
-
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.Signed-off-by: Bill Pemberton
Cc: Peter Korsgaard
Cc: Alexander Shishkin
Acked-by: Felipe Balbi
Cc: Li Yang
Cc: Alan Stern
Cc: Wan ZongShun
Cc: Ben Dooks
Cc: Kukjin Kim
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.Signed-off-by: Bill Pemberton
Cc: Peter Korsgaard
Cc: Alexander Shishkin
Acked-by: Felipe Balbi
Cc: Li Yang
Acked-by: Alan Stern
Cc: Geoff Levand
Cc: Wan ZongShun
Cc: Olav Kongas
Cc: Lennert Buytenhek
Cc: Ben Dooks
Cc: Kukjin Kim
Acked-by: Nicolas Ferre
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.Signed-off-by: Bill Pemberton
Cc: Peter Korsgaard
Cc: Alexander Shishkin
Acked-by: Felipe Balbi
Cc: Li Yang
Cc: Alan Stern
Cc: Wan ZongShun
Cc: Ben Dooks
Cc: Kukjin Kim
Acked-by: Nicolas Ferre
Acked-by: Peter Korsgaard
Signed-off-by: Greg Kroah-Hartman
13 Sep, 2012
3 commits
-
- let role driver handle irq before ID change check; this gives the
role driver a chance to handle disconnect;
- disable irq during switch role; no role driver to handle irq in
the period.Tested-by: Michael Grzeschik
Tested-by: Marc Kleine-Budde
Signed-off-by: Richard Zhao
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
In order to avoid re-queueing of the role changing work, we need to clear
the ID change interrupt bit right in the irq handler.Tested-by: Michael Grzeschik
Tested-by: Marc Kleine-Budde
Signed-off-by: Richard Zhao
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
The ID pin needs 1ms debounce time, even at probe time. We delay 2ms
to be on the safe side.Tested-by: Michael Grzeschik
Tested-by: Marc Kleine-Budde
Signed-off-by: Richard Zhao
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
10 Jul, 2012
3 commits
-
Sometimes, the driver bindings may know what phy they use.
For example, when using device tree, the usb controller may have a
phandler pointing to usb phy.Signed-off-by: Richard Zhao
Reviewed-by: Marek Vasut
Acked-by: Felipe Balbi
Tested-by: Subodh Nijsure
Signed-off-by: Greg Kroah-Hartman -
We use ida_simple_get and ida_simple_remove to manage the ids.
Signed-off-by: Richard Zhao
Reviewed-by: Felipe Balbi
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
Platform drivers do the similar things to add/remove ci13xxx device, so
create a unified one.Signed-off-by: Richard Zhao
Reviewed-by: Felipe Balbi
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
07 Jul, 2012
1 commit
-
This patch rename struct ci13xxx_udc_driver and var with the type.
ci13xxx_platform_data reflect it's passed from platfrom driver.
Signed-off-by: Richard Zhao
Reviewed-by: Felipe Balbi
Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman
15 May, 2012
1 commit
-
It's 0 for host only device.
Signed-off-by: Richard Zhao
Cc: Marek Vasut
Cc: Alan Stern
Cc: Alexander Shishkin
Cc: Felipe Balbi
Signed-off-by: Greg Kroah-Hartman
12 May, 2012
5 commits
-
This adds EHCI host support to the chipidea driver. We want it to be
part of the hdrc driver and not a standalone (sub-)driver module, as
the structure of ehci-hcd.c suggests, so for chipidea controller we
hack it to not provide platform-related code, but only the ehci hcd.The ehci-platform driver won't work for us here too, because the
controller uses the same registers for both device and host mode and
also otg-related bits, so it's not really possible to put ehci registers
into a separate resource.This is not a pretty solution, but the alternative is exporting symbols
from the chipidea driver to a ehci-chipidea driver and doing all the
module refcounting.Signed-off-by: Alexander Shishkin
Cc: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
Some of the bits of USBMODE register are defined in ,
use them instead of having our own definitions.Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
These definitions are unused, and the same registers are also defined
in .Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
Add some generic code for roles and implement simple role switching
based on ID pin state and/or a sysfs file. At this, we also rename
the device to ci_hdrc, which is what it is.The "manual" switch is made into a sysfs file and not debugfs, because
it might be useful even in non-debug context. For some boards, like
sheevaplug, it seems to be the only way to switch roles without modifying
the hardware, since the ID pin is always grounded.Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman -
Split the driver into the following parts:
* core -- resources, register access, capabilities, etc;
* udc -- device controller functionality;
* debug -- logging events.Signed-off-by: Alexander Shishkin
Signed-off-by: Greg Kroah-Hartman