29 Oct, 2012
1 commit
-
batadv_bit_get_packet checks for all common situations before it decides that
the new received packet indicates that the host was restarted. This extra
condition check at the end of the function is not necessary because this
condition is always true.This patch addresses Coverity #712296: Logically dead code
Signed-off-by: Sven Eckelmann
Signed-off-by: Antonio Quartulli
02 Jul, 2012
2 commits
-
Reported-by: Martin Hundebøll
Signed-off-by: Sven Eckelmann -
Reported-by: Martin Hundebøll
Signed-off-by: Sven Eckelmann
28 Jun, 2012
1 commit
-
Reported-by: Martin Hundebøll
Signed-off-by: Sven Eckelmann
25 Jun, 2012
2 commits
-
All non-static symbols of batman-adv were prefixed with batadv_ to avoid
collisions with other symbols of the kernel. Other symbols of batman-adv
should use the same prefix to keep the naming scheme consistent.Signed-off-by: Sven Eckelmann
-
All non-static symbols of batman-adv were prefixed with batadv_ to avoid
collisions with other symbols of the kernel. Other symbols of batman-adv
should use the same prefix to keep the naming scheme consistent.Signed-off-by: Sven Eckelmann
21 Jun, 2012
2 commits
-
batman-adv doesn't follow the style for multiline comments that David S. Miller
prefers. All comments should be reformatted to follow this consistent style to
make the code slightly more readable.Signed-off-by: Sven Eckelmann
-
batman-adv can be compiled as part of the kernel instead of an module. In that
case the linker will see all non-static symbols of batman-adv and all other
non-static symbols of the kernel. This could lead to symbol collisions. A
prefix for the batman-adv symbols that defines their private namespace avoids
such a problem.Reported-by: David Miller
Signed-off-by: Sven Eckelmann
11 Apr, 2012
1 commit
-
bitarray.c consists mostly of functionality that is already available as part
of the standard kernel API. batman-adv could use architecture optimized code
and reduce the binary size by switching to the standard functions.Signed-off-by: Sven Eckelmann
Signed-off-by: Antonio Quartulli
28 Feb, 2012
1 commit
-
Signed-off-by: Sven Eckelmann
Signed-off-by: Marek Lindner
17 Feb, 2012
1 commit
-
Signed-off-by: Sven Eckelmann
Signed-off-by: Marek Lindner
20 Nov, 2011
1 commit
-
The check for new packets in the future used a wrong binary operator,
which makes the check expression always true and accepting too many
packets.Reported-by: Thomas Jarosch
Signed-off-by: Simon Wunderlich
Signed-off-by: Sven Eckelmann
22 Aug, 2011
1 commit
-
Several typos have been corrected and some sentences have been rephrased
Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
20 Jun, 2011
2 commits
-
char was used in different places to store information without really
using the characteristics of that data type or by ignoring the fact that
char has not a well defined signedness.Signed-off-by: Sven Eckelmann
-
count_real_packets() in batman-adv assumes char is signed, and returns -1
through it:net/batman-adv/routing.c: In function 'receive_bat_packet':
net/batman-adv/routing.c:739: warning: comparison is always false due to limited range of data typeUse int instead.
Signed-off-by: David Howells
[sven@narfation.org: Rebase on top of current version]
Signed-off-by: Sven Eckelmann
30 May, 2011
2 commits
-
It is not necessary to cast a void* to the pointer type when we just
store it and don't want to do pointer arithmetic before the actual
assignment.Signed-off-by: Sven Eckelmann
-
batman-adv uses pointers which are marked as const and should not
violate that type qualifier by passing it to functions which force a
cast to the non-const version.Signed-off-by: Sven Eckelmann
31 Jan, 2011
1 commit
-
Signed-off-by: Sven Eckelmann
17 Dec, 2010
1 commit
-
B.A.T.M.A.N. (better approach to mobile ad-hoc networking) is a routing
protocol for multi-hop ad-hoc mesh networks. The networks may be wired or
wireless. See http://www.open-mesh.org/ for more information and user space
tools.Signed-off-by: Sven Eckelmann
Signed-off-by: David S. Miller