20 Aug, 2009
1 commit
-
The alignment calculation of xcbc_tfm_ctx uses alg->cra_alignmask
and not alg->cra_alignmask + 1 as it should. This led to frequent
crashes during the selftest of xcbc(aes-asm) on x86_64
machines. This patch fixes this. Also we use the alignmask
of xcbc and not the alignmask of the underlying algorithm
for the alignmnent calculation in xcbc_create now.Signed-off-by: Steffen Klassert
Signed-off-by: Herbert Xu
22 Jul, 2009
2 commits
-
Although xcbc was converted to shash, it didn't obey the new
requirement that all hash state must be stored in the descriptor
rather than the transform.This patch fixes this issue and also optimises away the rekeying
by precomputing K2 and K3 within setkey.Signed-off-by: Herbert Xu
-
This patch replaces the local xor function with the generic
crypto_xor function.Signed-off-by: Herbert Xu
15 Jul, 2009
1 commit
-
If shash_alloc_instance() fails, we return the wrong error value.
This patch fixes it.Signed-off-by: Herbert Xu
14 Jul, 2009
1 commit
-
This patch converts the xcbc algorithm to the new shash type.
Signed-off-by: Herbert Xu
02 Apr, 2008
1 commit
-
The kernel crashes when ipsec passes a udp packet of about 14XX bytes
of data to aes-xcbc-mac.It seems the first xxxx bytes of the data are in first sg entry,
and remaining xx bytes are in next sg entry. But we don't
check next sg entry to see if we need to go look the page up.I noticed in hmac.c, we do a scatterwalk_sg_next(), to do this check
and possible lookup, thus xcbc.c needs to use this routine too.A 15-hour run of an ipsec stress test sending streams of tcp and
udp packets of various sizes, using this patch and
aes-xcbc-mac completed successfully, so hopefully this fixes the
problem.Signed-off-by: Joy Latten
Signed-off-by: Herbert Xu
06 Mar, 2008
1 commit
-
When using aes-xcbc-mac for authentication in IPsec,
the kernel crashes. It seems this algorithm doesn't
account for the space IPsec may make in scatterlist for authtag.
Thus when crypto_xcbc_digest_update2() gets called,
nbytes may be less than sg[i].length.
Since nbytes is an unsigned number, it wraps
at the end of the loop allowing us to go back
into loop and causing crash in memcpy.I used update function in digest.c to model this fix.
Please let me know if it looks ok.Signed-off-by: Joy Latten
Signed-off-by: Herbert Xu
08 Feb, 2008
1 commit
-
Convert instances of ERR_PTR(PTR_ERR(p)) to ERR_CAST(p) using:
perl -spi -e 's/ERR_PTR[(]PTR_ERR[(](.*)[)][)]/ERR_CAST(\1)/' `grep -rl 'ERR_PTR[(]*PTR_ERR' fs crypto net security`
Signed-off-by: David Howells
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Jan, 2008
3 commits
-
When setting the digest size xcbc tests to see if the underlying algorithm
is a hash. This is silly because we don't allow it to be a hash and we've
specifically requested for a cipher.This patch removes the bogus test.
Signed-off-by: Herbert Xu
-
When the underlying algorithm has a block size other than 16 we abort
without freeing it. In fact, we try to return the algorithm itself
as an error!This patch plugs the leak and makes it return -EINVAL instead.
Signed-off-by: Herbert Xu
-
The scatterwalk infrastructure is used by algorithms so it needs to
move out of crypto for future users that may live in drivers/crypto
or asm/*/crypto.Signed-off-by: Herbert Xu
23 Oct, 2007
1 commit
-
Signed-off-by: Jens Axboe
02 May, 2007
1 commit
-
This patch passes the type/mask along when constructing instances of
templates. This is in preparation for templates that may support
multiple types of instances depending on what is requested. For example,
the planned software async crypto driver will use this construct.For the moment this allows us to check whether the instance constructed
is of the correct type and avoid returning success if the type does not
match.Signed-off-by: Herbert Xu
07 Feb, 2007
3 commits
-
This patch changes xcbc to use the new cipher encryt_one interface.
Signed-off-by: Herbert Xu
-
This patch allows spawns of specific types (e.g., cipher) to be allocated.
Signed-off-by: Herbert Xu
-
Using blkcipher/hash crypto operations in hard IRQ context can lead
to random memory corruption due to the reuse of kmap_atomic slots.
Since crypto operations were never meant to be used in hard IRQ
contexts, this patch checks for such usage and returns an error
before kmap_atomic is performed.Signed-off-by: Herbert Xu
07 Dec, 2006
2 commits
-
On Tue, Nov 14, 2006 at 01:41:25AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc5-mm2:
>...
> git-cryptodev.patch
>...
> git trees
>...This patch makes some needlessly global code static.
Signed-off-by: Adrian Bunk
Signed-off-by: Herbert Xu -
This is core code of XCBC.
XCBC is an algorithm that forms a MAC algorithm out of a cipher algorithm.
For example, AES-XCBC-MAC is a MAC algorithm based on the AES cipher
algorithm.Signed-off-by: Kazunori MIYAZAWA
Signed-off-by: Herbert Xu
