03 Jun, 2013
1 commit
-
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.Signed-off-by: Jingoo Han
Signed-off-by: Marc Kleine-Budde
27 Mar, 2013
1 commit
-
This patch fixes the following sparse warning:
drivers/net/can/bfin_can.c:415:13: warning: symbol 'bfin_can_interrupt' was not declared. Should it be static?
drivers/net/can/bfin_can.c:507:19: warning: symbol 'alloc_bfin_candev' was not declared. Should it be static?Signed-off-by: Marc Kleine-Budde
04 Dec, 2012
1 commit
-
CONFIG_HOTPLUG is going away as an option. As result the __dev*
markings will be going away.Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.Signed-off-by: Bill Pemberton
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Cc: linux-can@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman
27 Nov, 2012
1 commit
-
This patch adds a MODULE_ALIAS for the platform bindings, so that the module
can be loaded automatically by udev.Signed-off-by: Marc Kleine-Budde
20 Jul, 2012
1 commit
-
This patch marks the bittiming_const pointer as in the struct can_pric as
"const". This allows us to mark the struct can_bittiming_const in the CAN
drivers as "const", too.Signed-off-by: Marc Kleine-Budde
07 Jun, 2012
1 commit
-
Adding casts of objects to the same type is unnecessary
and confusing for a human reader.For example, this cast:
int y;
int *p = (int *)&y;I used the coccinelle script below to find and remove these
unnecessary casts. I manually removed the conversions this
script produces of casts with __force, __iomem and __user.@@
type T;
T *p;
@@- (T *)p
+ pSigned-off-by: Joe Perches
Signed-off-by: David S. Miller
03 Feb, 2012
2 commits
-
Cc: uclinux-dist-devel@blackfin.uclinux.org
Cc: Anant Gole
Cc: Chris Elston
Cc: Sebastian Haas
Cc: Matthias Fuchs
Signed-off-by: Wolfgang Grandegger
Acked-by: Sebastian Haas
Acked-by: Mike Frysinger
Signed-off-by: Marc Kleine-Budde -
Cc: Anant Gole
Signed-off-by: Wolfgang Grandegger
Signed-off-by: Marc Kleine-Budde
29 Nov, 2011
1 commit
-
This patch converts the drivers in drivers/net/can/* to use the
module_platform_driver() macro which makes the code smaller and a bit
simpler.Cc: Wolfgang Grandegger
Cc: "David S. Miller"
Cc: Bhupesh Sharma
Cc: Jiri Kosina
Cc: Grant Likely
Cc: Anatolij Gustschin
Cc: Paul Bolle
Cc: Kurt Van Dijck
Cc: Alexey Dobriyan
Signed-off-by: Axel Lin
Acked-by: Marc Kleine-Budde
Signed-off-by: David S. Miller
28 Jun, 2011
2 commits
-
Since we have a struct that defines the sizes of the registers, we don't
need to explicitly use the 16bit read/write helpers. Let the code figure
out which size access to make based on the size of the C type.There should be no functional changes here.
Signed-off-by: Mike Frysinger
Acked-by: Wolfgang Grandegger
Signed-off-by: David S. Miller -
If we look closely, the 4 writes to TRANSMIT_CHL.id1 can be collapsed
down into much simpler code. So do just that.This also fixes a build failure due to the I/O macros no longer
getting pulled in. Their minor (and accidental) usage here gets
dropped as part of the unification.Signed-off-by: Mike Frysinger
Acked-by: Wolfgang Grandegger
Acked-by: Kurt Van Dijck
Signed-off-by: David S. Miller
10 May, 2010
1 commit
-
Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.Exceptions are NETIF_F_LLTX drivers
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
13 Apr, 2010
1 commit
-
In the current implementation, CAN drivers need to #include
_before_ they #include , which is both ugly and
unnecessary.Fix this by including in and remove the
#include lines from drivers.Signed-off-by: Hans J. Koch
Signed-off-by: David S. Miller
23 Mar, 2010
1 commit
-
The MMR bits are being moved to this header, so include it.
Signed-off-by: Mike Frysinger
Acked-by: Wolfgang Grandegger
Signed-off-by: David S. Miller
09 Mar, 2010
1 commit
-
Looks like commit a6e4bc530403 didn't include updates to drivers so the
Blackfin CAN driver fails to build now.Signed-off-by: Barry Song
Signed-off-by: Mike Frysinger
Acked-by: Wolfgang Grandegger
Signed-off-by: David S. Miller
15 Jan, 2010
1 commit
-
This patch adds error checking of ctrlmode values for CAN devices. As
an example all availabe bits are implemented in the mcp251x driver.Signed-off-by: Christian Pellegrin
Acked-by: Wolfgang Grandegger
Signed-off-by: David S. Miller
12 Jan, 2010
1 commit
-
To prevent the CAN drivers to operate on invalid socketbuffers the skbs are
now checked and silently dropped at the xmit-function consistently.Also the netdev stats are consistently using the CAN data length code (dlc)
for [rx|tx]_bytes now.Signed-off-by: Oliver Hartkopp
Acked-by: Wolfgang Grandegger
Signed-off-by: David S. Miller
14 Dec, 2009
1 commit
-
A valid CAN dataframe can have a data length code (DLC) of 0 .. 8 data bytes.
When reading the CAN controllers register the 4-bit value may contain values
from 0 .. 15 which may exceed the reserved space in the socket buffer!The ISO 11898-1 Chapter 8.4.2.3 (DLC field) says that register values > 8
should be reduced to 8 without any error reporting or frame drop.This patch introduces a new helper macro to cast a given 4-bit data length
code (dlc) to __u8 and ensure the DLC value to be max. 8 bytes.The different handlings in the rx path of the CAN netdevice drivers are fixed.
Signed-off-by: Oliver Hartkopp
Signed-off-by: Wolfgang Grandegger
Signed-off-by: David S. Miller
12 Dec, 2009
1 commit
-
Signed-off-by: Barry Song
Signed-off-by: H.J. Oertel
Signed-off-by: Wolfgang Grandegger
Signed-off-by: David S. Miller