13 Jul, 2010
1 commit
-
Signed-off-by: Joe Perches
Signed-off-by: Stefan Richter
01 Jun, 2010
1 commit
-
...when user data is immediately copied into the allocated region.
Signed-off-by: Julia Lawall
Signed-off-by: Stefan Richter (changelog)
10 Apr, 2010
1 commit
-
The
- raw1394 (/dev/raw1394),
- video1394 (/dev/video1394/*),
- dv1394 (/dev/dv1394/*)
character device file ABIs do not make any use of lseek(), pread(), or
pwrite(). Therefore use nonseekable_open() and, redundantly, set
file_operations.llseek to no_llseek to remove any doubt whether the BKL-
grabbing default_llseek handler is used.Although all this is legacy code which should be left in peace until it
is eventually removed (as it is superseded by firewire-core's
ABI), this change seems still worth doing to
further minimize the presence of BKL usage in the kernel.Signed-off-by: Stefan Richter
12 Oct, 2009
1 commit
-
After m68k's task_thread_info() doesn't refer to current,
it's possible to remove sched.h from interrupt.h and not break m68k!
Many thanks to Heiko Carstens for allowing this.Signed-off-by: Alexey Dobriyan
25 Mar, 2009
1 commit
-
Signed-off-by: Stefan Richter
17 Oct, 2008
2 commits
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
firewire: Add more documentation to firewire-cdev.h
firewire: fix ioctl() return code
firewire: fix setting tag and sy in iso transmission
firewire: fw-sbp2: fix another small generation access bug
firewire: fw-sbp2: enforce s/g segment size limit
firewire: fw_send_request_sync()
ieee1394: survive a few seconds connection loss
ieee1394: nodemgr clean up class iterators
ieee1394: dv1394, video1394: remove unnecessary expressions
ieee1394: raw1394: make write() thread-safe
ieee1394: raw1394: narrow down the state_mutex protected region
ieee1394: raw1394: replace BKL by local mutex, make ioctl() and mmap() thread-safe
ieee1394: sbp2: enforce s/g segment size limit
ieee1394: sbp2: check for DMA mapping failures
ieee1394: sbp2: stricter dma_sync
ieee1394: Use DIV_ROUND_UP -
Now that device_create() has been audited, rename things back to the
original call to be sane.Cc: Ben Collins
Acked-by: Stefan Richter
Signed-off-by: Greg Kroah-Hartman
16 Oct, 2008
1 commit
-
init->channel and v.buffer are unsigned and tests for < 0 therefore
always false. gcc knows this and eliminates the code, but anyway...
Reported by Roel Kluin.Signed-off-by: Stefan Richter
22 Jul, 2008
1 commit
-
device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.Cc: Ben Collins
Acked-by: Stefan Richter
Signed-off-by: Greg Kroah-Hartman
14 Jul, 2008
1 commit
-
This prepares video1394 for removal of the BKL (big kernel lock):
It allows video1394_open() to be called while video1394_init_module()
is still in progress.Signed-off-by: Stefan Richter
26 Apr, 2008
1 commit
-
Currently the kernel will issue the following warning:
drivers/ieee1394/raw1394.c:2938: warning: 'raw1394_id_table' defined but not used
Add #ifdef MODULE guards around the declaration.Signed-off-by: Tony Breeds
Ditto with dv1394_id_table and video1394_id_table.
Signed-off-by: Stefan Richter
18 Apr, 2008
2 commits
-
Unless you're adding a kobject to the sysfs hierarchy, there is no
point setting its kobject name.Signed-off-by: Robert P. J. Day
Signed-off-by: Stefan Richter -
These drivers don't need to match any unit_directory type device.
They just need the id_table for module autoloading per module alias.Not binding any of these drivers allows special-purpose drivers with
similar or same IDs to bind to devices. This currently only benefits
out-of-tree drivers; on the other hand it is in no way detrimental to
in-tree drivers.Signed-off-by: Stefan Richter
10 Jul, 2007
1 commit
-
Here is a straightforward conversion to "struct device". The "struct
class_device" will be removed from the kernel.It seems to work fine for me with and without CONFIG_SYSFS_DEPRECATED
set.Signed-off-by: Stefan Richter
09 May, 2007
1 commit
-
Remove includes of where it is not used/needed.
Suggested by Al Viro.Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc,
sparc64, and arm (all 59 defconfigs).Signed-off-by: Randy Dunlap
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
13 Feb, 2007
1 commit
-
Many struct file_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.Signed-off-by: Arjan van de Ven
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 Feb, 2007
1 commit
-
This together with the phys_to_virt fix in lib/swiotlb.c::swiotlb_sync_sg
fixes video1394 DMA on machines with DMA bounce buffers, especially Intel
x86-64 machines with > 3GB RAM.Signed-off-by: Stefan Richter
Signed-off-by: David Moore
Tested-by: Nicolas Turro
08 Dec, 2006
3 commits
-
This patch consolidates some bookkeeping for driver registering. It
closely models what pci_register_driver() does. The main addition is
that the owner of the driver is set, so we get a proper symlink
for /sys/bus/ieee1394/driver/*/module.Also moves setting of name and bus type into nodemgr. Because of this,
we can remove the EXPORT_SYMBOL for ieee1394_bus_type, since it's now
only used in ieee1394.ko.Signed-off-by: Stefan Richter
-
video1394 does not need to take the BKL. The data structures shared between
file_operations and interrupts are already protected through context-specific
spinlocks.The only other danger is video1394_release() being called during another
operation, however this cannot happen because release is only ever invoked
when the last thread has closed the fd.Signed-off-by: Daniel Drake
Signed-off-by: Stefan Richter -
Add some GCC branch prediction optimizations to unlikely error/safety
conditions in the ioctl handling code commonly called during an application's
capture loop.Signed-off-by: Daniel Drake
Signed-off-by: Stefan Richter
18 Sep, 2006
2 commits
-
A deactivated macro, defined as "#define foo(bar)", will result in
silent corruption if somebody forgets a semicolon after a call to foo.
Replace it by "#define foo(bar) do {} while (0)" which will reveal any
respective syntax errors.Signed-off-by: Stefan Richter
-
This patch adds support for the poll file operation to the video1394
driver.Signed-off-by: David Moore
Signed-off-by: Stefan Richter
04 Jul, 2006
1 commit
-
Remove unnecessary includes, add missing includes.
Use forward type declarations for some structs.Signed-off-by: Stefan Richter
Signed-off-by: Ben Collins
01 Jul, 2006
1 commit
-
Signed-off-by: Jörn Engel
Signed-off-by: Adrian Bunk
13 Jun, 2006
1 commit
-
When working with multiple cameras and intensive applications, our logs
get flooded with video1394 information which isn't of much interest.Any objections to demoting these messages to debug messages?
Signed-off-by: Daniel Drake
Signed-off-by: Ben Collins
29 Mar, 2006
1 commit
-
Devfs has been disabled in the last kernel releases, so let's
remove it from ieee1394core, raw1394, video1394, dv1394.Signed-off-by: Stefan Richter
Acked-by: Greg Kroah-Hartman
Cc: Dan Dennedy
Signed-off-by: Jody McIntyre
01 Mar, 2006
1 commit
-
Signed-off-by: Alexey Dobriyan
Cc: Ben Collins
Cc: Jody McIntyre
Cc: Stefan Richter
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Jan, 2006
1 commit
-
These days ioctl32.h is only used for communication of fs/compat.c and
fs/compat_ioctl.c and doesn't contain anything of interest to drivers.Remove inclusion in various drivers.
Signed-off-by: Christoph Hellwig
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
20 Nov, 2005
1 commit
-
This patch fixes the incoherent timestamps generated by video1394 since
the single-buffer patch was applied in 2.6.11. Credits have also been
removed from the header and a "//" comment was changed to "/* */".Signed-off-by: Damien Douxchamps
Signed-off-by: Jody McIntyre
07 Nov, 2005
2 commits
-
dv1394 and video1394.
Signed-off-by: Stefan Richter
Signed-off-by: Jody McIntyre -
dv1394, eth1394, ieee1394, ohci1394, pcilynx, raw1394, sbp2c, video1394:
- use kzalloc
- provide safer size arguments to kmalloc and kzalloc
- omit some castsSigned-off-by: Stefan Richter
Signed-off-by: Jody McIntyre
29 Oct, 2005
1 commit
-
The previous patch adding the ability to nest struct class_device
changed the paramaters to the call class_device_create(). This patch
fixes up all in-kernel users of the function.Signed-off-by: Greg Kroah-Hartman
01 Oct, 2005
1 commit
-
amdtp, dv1394, raw1394, video1394:
Delete legacy module aliases. The macros did not work and the aliases are not
needed nowadays.Signed-off-by: Stefan Richter
Signed-off-by: Ben Collins
Signed-off-by: Jody McIntyre
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
10 Sep, 2005
1 commit
-
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
21 Jun, 2005
1 commit
-
Signed-off-by: Greg Kroah-Hartman
17 May, 2005
2 commits
-
Apply and fixup patch from Markus Tavenrath for
video1394 to allow only a single buffer on receive and two buffers on
transmit. Tested with libdc1394 and dvconnect (libdv).Signed-off-by: Dan Dennedy
Signed-off-by: Jody McIntyre
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
This patch removes redundant NULL pointer checks before kfree() in all of
drivers/ieee1394/Signed-off-by: Jesper Juhl
Signed-off-by: Jody McIntyre
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
