12 Feb, 2013
1 commit
-
alloc failures already get standardized OOM
messages and a dump_stack.For the affected mallocs around these OOM messages:
Converted kzallocs with multiplies to kcalloc.
Converted kmallocs with multiplies to kmalloc_array.
Converted a kmalloc/strlen/strncpy to kstrdup.
Moved a spin_lock below a removed OOM message and
removed a now unnecessary spin_unlock.
Neatened alignment and whitespace.Signed-off-by: Joe Perches
Signed-off-by: Greg Kroah-Hartman
12 Jan, 2013
1 commit
-
Allowi() calls usb_submit_urb(pdx->pUrbCharIn, bInCallback ? GFP_ATOMIC : GFP_KERNEL)
under spin_lock_irqsave(&pdx->charInLock, flags). That means it should use GFP_ATOMIC anyway.
As soon as it is the only usage of bInCallback argument, the patch removes it at all.Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
Signed-off-by: Greg Kroah-Hartman
27 Nov, 2012
1 commit
-
Correct spelling typo in comments within staging/ced1401
Signed-off-by: Masanari Iida
Signed-off-by: Greg Kroah-Hartman
31 Oct, 2012
1 commit
-
Casting value returned by k[cmz]alloc to (struct page * *) is useless.
Generated by: scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci
Reported-by: Fengguang Wu
Signed-off-by: Greg Kroah-Hartman
27 Oct, 2012
1 commit
-
Remove including that don't need it.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)Signed-off-by: Wei Yongjun
Signed-off-by: Greg Kroah-Hartman
24 Oct, 2012
1 commit
-
gcc/sparse complain about the following:
drivers/staging/ced1401/ced_ioc.c:931:1: warning: the frame size of 4144 bytes is larger than 2048 bytes [-Wframe-larger-than=]
Fix it by dynamically allocating it.
Signed-off-by: Devendra Naga
Signed-off-by: Greg Kroah-Hartman
23 Oct, 2012
4 commits
-
Add the missing unlock on the error handle path in function
FreeCircBlock().Signed-off-by: Wei Yongjun
Signed-off-by: Greg Kroah-Hartman -
We dont need these kernel versioning checks anyways.
Signed-off-by: Devendra Naga
Signed-off-by: Greg Kroah-Hartman -
this fixes:
comments to in kernel comment style
the opening brace of if statement must be beside the if not below
to itSigned-off-by: Devendra Naga
Signed-off-by: Greg Kroah-Hartman -
in disconnect we assign the device minor number from the interface
pointer to the localvarible minor, and then print it at the end,this code seems self explanatory so remove the comment of assigning
the minor number to a local variable.Signed-off-by: Devendra Naga
Signed-off-by: Greg Kroah-Hartman
21 Sep, 2012
3 commits
-
As the driver says that read and writes should not be performed
and instead the user to kernel transactions are performed through
ioctl interface, remove these functions as they are not requiredSigned-off-by: Devendra Naga
Signed-off-by: Greg Kroah-Hartman -
the module init and exit functions that are
doing usb_register and usb_deregister respectively can be
replaced with module_usb_driver codeSigned-off-by: Devendra Naga
Signed-off-by: Greg Kroah-Hartman -
nArea is used as an offset into the ->rTransDef[] array which has
MAX_TRANSAREAS elements.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
18 Sep, 2012
6 commits
-
Properly check the return value of copy_from/to_user() and handle any
errors that might happen.This removes a bunch of compiler warnings.
Cc: Alois Schlögl
Cc: Greg P. Smith
Signed-off-by: Greg Kroah-Hartman -
A basic Lindent run on the .c files, clean up the .h file by hand.
Cc: Alois Schlögl
Cc: Greg P. Smith
Signed-off-by: Greg Kroah-Hartman -
This adds the ced1401 driver to the build system.
Yes, there are a lot of warning messages, but it does compile, so it
should be good to get going.Cc: Alois Schlögl
Cc: Greg P. Smith
Signed-off-by: Greg Kroah-Hartman -
This adds a first cut of a TODO file to get this driver out of the
staging directory.Cc: Alois Schlögl
Cc: Greg P. Smith
Signed-off-by: Greg Kroah-Hartman -
This fixes up the usb1401.c file to remove the usage of err() (which is
gone), and the two-argument kmap_atomic() call, and the compat_ioctl
pointer warning.The code now builds properly, there are lots of warnings still, but it's
a start.Cc: Alois Schlögl
Cc: Greg P. Smith
Signed-off-by: Greg Kroah-Hartman -
This was imported from the
http://pub.ist.ac.at/~schloegl/src/ced1401/.git git repo at the request
of Alois. The driver originally came from Cambridge Electronic Design
Ltd and was authored by Greg P Smith and others, but Alois did the
maintance work to get it into a semi-building state and pushed to get it
into the main kernel tree here.Cc: Alois Schlögl
Cc: Greg P. Smith
Signed-off-by: Greg Kroah-Hartman
