22 Feb, 2013

1 commit

  • This patch enhances the IB core support for Memory Windows (MWs).

    MWs allow an application to have better/flexible control over remote
    access to memory.

    Two types of MWs are supported, with the second type having two flavors:

    Type 1 - associated with PD only
    Type 2A - associated with QPN only
    Type 2B - associated with PD and QPN

    Applications can allocate a MW once, and then repeatedly bind the MW
    to different ranges in MRs that are associated to the same PD. Type 1
    windows are bound through a verb, while type 2 windows are bound by
    posting a work request.

    The 32-bit memory key is composed of a 24-bit index and an 8-bit
    key. The key is changed with each bind, thus allowing more control
    over the peer's use of the memory key.

    The changes introduced are the following:

    * add memory window type enum and a corresponding parameter to ib_alloc_mw.
    * type 2 memory window bind work request support.
    * create a struct that contains the common part of the bind verb struct
    ibv_mw_bind and the bind work request into a single struct.
    * add the ib_inc_rkey helper function to advance the tag part of an rkey.

    Consumer interface details:

    * new device capability flags IB_DEVICE_MEM_WINDOW_TYPE_2A and
    IB_DEVICE_MEM_WINDOW_TYPE_2B are added to indicate device support
    for these features.

    Devices can set either IB_DEVICE_MEM_WINDOW_TYPE_2A or
    IB_DEVICE_MEM_WINDOW_TYPE_2B if it supports type 2A or type 2B
    memory windows. It can set neither to indicate it doesn't support
    type 2 windows at all.

    * modify existing provides and consumers code to the new param of
    ib_alloc_mw and the ib_mw_bind_info structure

    Signed-off-by: Haggai Eran
    Signed-off-by: Shani Michaeli
    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Shani Michaeli
     

03 Jan, 2013

1 commit


22 Nov, 2012

1 commit


07 Oct, 2012

1 commit


01 Oct, 2012

2 commits

  • When P_Key tables potentially contain both full and partial membership
    copies for the same P_Key, we need a function to find the index for an
    exact (16-bit) P_Key.

    This is necessary when the master forwards QP1 MADs sent by guests.
    If the guest has sent the MAD with a limited membership P_Key, we need
    to to forward the MAD using the same limited membership P_Key. Since
    the master may have both the limited and the full member P_Keys in its
    table, we must make sure to retrieve the limited membership P_Key in
    this case.

    Signed-off-by: Jack Morgenstein
    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Jack Morgenstein
     
  • Reserve bits 26-31 for internal use by low-level drivers. Two such
    bits are used in the mlx4_b driver SR-IOV implementation.

    These enum additions guarantee that the core layer will never use
    these bits, so that low level drivers may safely make use of them.

    Signed-off-by: Jack Morgenstein
    Signed-off-by: Roland Dreier

    Jack Morgenstein
     

23 Jul, 2012

1 commit


09 Jul, 2012

3 commits


22 May, 2012

1 commit


19 May, 2012

1 commit


09 May, 2012

2 commits

  • IB_QPT_RAW_PACKET allows applications to build a complete packet,
    including L2 headers, when sending; on the receive side, the HW will
    not strip any headers.

    This QP type is designed for userspace direct access to Ethernet; for
    example by applications that do TCP/IP themselves. Only processes
    with the NET_RAW capability are allowed to create raw packet QPs (the
    name "raw packet QP" is supposed to suggest an analogy to AF_PACKET /
    SOL_RAW sockets).

    Signed-off-by: Or Gerlitz
    Reviewed-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Or Gerlitz
     
  • Just as we don't allow PDs, CQs, etc. to be destroyed if there are QPs
    that are attached to them, don't let a QP be destroyed if there are
    multicast group(s) attached to it. Use the existing usecnt field of
    struct ib_qp which was added by commit 0e0ec7e ("RDMA/core: Export
    ib_open_qp() to share XRC TGT QPs") to track this.

    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Or Gerlitz
     

20 Mar, 2012

1 commit


09 Mar, 2012

1 commit

  • Use a bit in wc_flags rather then a whole integer to hold the
    "checksum OK" flag. By itself, this change doesn't reduce the size of
    struct ib_wc on 64bit machines -- it stays on 56 bytes because of
    padding. However, it will allow to add more fields in the future
    without enlarging the struct. Also, it will let us have a unified
    approach with future libibverbs checksum offload reporting, because a
    bit flag doesn't break the library ABI.

    This patch was suggested during conversation with Liran Liss
    .

    Signed-off-by: Or Gerlitz
    Reviewed-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Or Gerlitz
     

06 Mar, 2012

1 commit

  • The kernel IB stack uses one enumeration for IB speed, which wasn't
    explicitly specified in the verbs header file. Add that enum, and use
    it all over the code.

    The IB speed/width notation is also used by iWARP and IBoE HW drivers,
    which use the convention of rate = speed * width to advertise their
    port link rate.

    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Or Gerlitz
     

26 Feb, 2012

1 commit


05 Jan, 2012

1 commit


02 Nov, 2011

2 commits

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband: (62 commits)
    mlx4_core: Deprecate log_num_vlan module param
    IB/mlx4: Don't set VLAN in IBoE WQEs' control segment
    IB/mlx4: Enable 4K mtu for IBoE
    RDMA/cxgb4: Mark QP in error before disabling the queue in firmware
    RDMA/cxgb4: Serialize calls to CQ's comp_handler
    RDMA/cxgb3: Serialize calls to CQ's comp_handler
    IB/qib: Fix issue with link states and QSFP cables
    IB/mlx4: Configure extended active speeds
    mlx4_core: Add extended port capabilities support
    IB/qib: Hold links until tuning data is available
    IB/qib: Clean up checkpatch issue
    IB/qib: Remove s_lock around header validation
    IB/qib: Precompute timeout jiffies to optimize latency
    IB/qib: Use RCU for qpn lookup
    IB/qib: Eliminate divide/mod in converting idx to egr buf pointer
    IB/qib: Decode path MTU optimization
    IB/qib: Optimize RC/UC code by IB operation
    IPoIB: Use the right function to do DMA unmap pages
    RDMA/cxgb4: Use correct QID in insert_recv_cqe()
    RDMA/cxgb4: Make sure flush CQ entries are collected on connection close
    ...

    Linus Torvalds
     
  • …sc', 'mlx4', 'misc', 'nes', 'qib' and 'xrc' into for-next

    Roland Dreier
     

14 Oct, 2011

10 commits

  • Allow processes that share the same XRC domain to open an existing
    shareable QP. This permits those processes to receive events on the
    shared QP and transfer ownership, so that any process may modify the
    QP. The latter allows the creating process to exit, while a remaining
    process can still transition it for path migration purposes.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • XRC TGT QPs are shared resources among multiple processes. Since the
    creating process may exit, allow other processes which share the same
    XRC domain to open an existing QP. This allows us to transfer
    ownership of an XRC TGT QP to another process.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • Allow the user to indicate the QP type separately from the port space
    when allocating an rdma_cm_id. With RDMA_PS_IB, there is no longer a
    1:1 relationship between the QP type and port space, so we need to
    switch on the QP type to select between UD and connected QPs.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • Add RDMA_PS_IB. XRC QP types will use the IB port space when operating
    over the RDMA CM. For the 'IP protocol' field value, we select 0x3F,
    which is listed as being for 'any local network'.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • We require additional information to create XRC SRQs than we can
    exchange using the existing create SRQ ABI. Provide an enhanced create
    ABI for extended SRQ types.

    Based on patches by Jack Morgenstein
    and Roland Dreier

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • Allow user space to create XRC domains. Because XRCDs are expected to
    be shared among multiple processes, we use inodes to identify an XRCD.

    Based on patches by Jack Morgenstein

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • XRC TGT QPs are intended to be shared among multiple users and
    processes. Allow the destruction of an XRC TGT QP to be done explicitly
    through ib_destroy_qp() or when the XRCD is destroyed.

    To support destroying an XRC TGT QP, we need to track TGT QPs with the
    XRCD. When the XRCD is destroyed, all tracked XRC TGT QPs are also
    cleaned up.

    To avoid stale reference issues, if a user is holding a reference on a
    TGT QP, we increment a reference count on the QP. The user releases the
    reference by calling ib_release_qp. This releases any access to the QP
    from a user above verbs, but allows the QP to continue to exist until
    destroyed by the XRCD.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • XRC ("eXtended reliable connected") is an IB transport that provides
    better scalability by allowing senders to specify which shared receive
    queue (SRQ) should be used to receive a message, which essentially
    allows one transport context (QP connection) to serve multiple
    destinations (as long as they share an adapter, of course).

    XRC communication is between an initiator (INI) QP and a target (TGT)
    QP. Target QPs are associated with SRQs through an XRCD. An XRC TGT QP
    behaves like a receive-only RD QP. XRC INI QPs behave similarly to RC
    QPs, except that work requests posted to an XRC INI QP must specify the
    remote SRQ that is the target of the work request.

    We define two new QP types for XRC, to distinguish between INI and TGT
    QPs, and update the core layer to support XRC QPs.

    This patch is derived from work by Jack Morgenstein

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • XRC ("eXtended reliable connected") is an IB transport that provides
    better scalability by allowing senders to specify which shared receive
    queue (SRQ) should be used to receive a message, which essentially
    allows one transport context (QP connection) to serve multiple
    destinations (as long as they share an adapter, of course).

    XRC defines SRQs that are specifically used by XRC connections. Expand
    the SRQ code to support XRC SRQs. An XRC SRQ is currently restricted to
    only XRC use according to the IB XRC Annex.

    Portions of this patch were derived from work by
    Jack Morgenstein .

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     
  • Currently, there is only a single ("basic") type of SRQ, but with XRC
    support we will add a second. Prepare for this by defining an SRQ type
    and setting all current users to IB_SRQT_BASIC.

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     

13 Oct, 2011

1 commit

  • XRC ("eXtended reliable connected") is an IB transport that provides
    better scalability by allowing senders to specify which shared receive
    queue (SRQ) should be used to receive a message, which essentially
    allows one transport context (QP connection) to serve multiple
    destinations (as long as they share an adapter, of course).

    A few new concepts are introduced to support this. This patch adds:

    - A new device capability flag, IB_DEVICE_XRC, which low-level
    drivers set to indicate that a device supports XRC.
    - A new object type, XRC domains (struct ib_xrcd), and new verbs
    ib_alloc_xrcd()/ib_dealloc_xrcd(). XRCDs are used to limit which
    XRC SRQs an incoming message can target.

    This patch is derived from work by Jack Morgenstein .

    Signed-off-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Sean Hefty
     

12 Oct, 2011

1 commit

  • Introduce support for the following extended speeds:

    FDR-10: a Mellanox proprietary link speed which is 10.3125 Gbps with
    64b/66b encoding rather than 8b/10b encoding.
    FDR: IBA extended speed 14.0625 Gbps.
    EDR: IBA extended speed 25.78125 Gbps.

    Signed-off-by: Marcel Apfelbaum
    Reviewed-by: Hal Rosenstock
    Reviewed-by: Sean Hefty
    Signed-off-by: Roland Dreier

    Marcel Apfelbaum
     

07 Oct, 2011

1 commit


16 Sep, 2011

1 commit

  • This patch does several things:
    - introduces __ethtool_get_settings which is called from ethtool code and
    from drivers as well. Put ASSERT_RTNL there.
    - dev_ethtool_get_settings() is replaced by __ethtool_get_settings()
    - changes calling in drivers so rtnl locking is respected. In
    iboe_get_rate was previously ->get_settings() called unlocked. This
    fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same
    problem. Also fixed by calling __dev_get_by_index() instead of
    dev_get_by_index() and holding rtnl_lock for both calls.
    - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create()
    so bnx2fc_if_create() and fcoe_if_create() are called locked as they
    are from other places.
    - use __ethtool_get_settings() in bonding code

    Signed-off-by: Jiri Pirko

    v2->v3:
    -removed dev_ethtool_get_settings()
    -added ASSERT_RTNL into __ethtool_get_settings()
    -prb_calc_retire_blk_tmo - use __dev_get_by_index() and lock
    around it and __ethtool_get_settings() call
    v1->v2:
    add missing export_symbol
    Reviewed-by: Ben Hutchings [except FCoE bits]
    Acked-by: Ralf Baechle
    Signed-off-by: David S. Miller

    Jiri Pirko
     

27 Jul, 2011

1 commit

  • This allows us to move duplicated code in
    (atomic_inc_not_zero() for now) to

    Signed-off-by: Arun Sharma
    Reviewed-by: Eric Dumazet
    Cc: Ingo Molnar
    Cc: David Miller
    Cc: Eric Dumazet
    Acked-by: Mike Frysinger
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arun Sharma
     

19 Jul, 2011

2 commits

  • Move the various definitions and mad structures needed for software
    implementation of IBA PM agent from the ipath and qib drivers into a
    single include file, which in turn could be used by more consumers.

    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Or Gerlitz
     
  • Add IB GID change event type. This is needed for IBoE when the HW
    driver updates the GID (e.g when new VLANs are added/deleted) table
    and the change should be reflected to the IB core cache.

    Signed-off-by: Eli Cohen
    Signed-off-by: Or Gerlitz
    Signed-off-by: Roland Dreier

    Or Gerlitz
     

27 May, 2011

1 commit

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband:
    RDMA/cma: Save PID of ID's owner
    RDMA/cma: Add support for netlink statistics export
    RDMA/cma: Pass QP type into rdma_create_id()
    RDMA: Update exported headers list
    RDMA/cma: Export enum cma_state in
    RDMA/nes: Add a check for strict_strtoul()
    RDMA/cxgb3: Don't post zero-byte read if endpoint is going away
    RDMA/cxgb4: Use completion objects for event blocking
    IB/srp: Fix integer -> pointer cast warnings
    IB: Add devnode methods to cm_class and umad_class
    IB/mad: Return EPROTONOSUPPORT when an RDMA device lacks the QP required
    IB/uverbs: Add devnode method to set path/mode
    RDMA/ucma: Add .nodename/.mode to tell userspace where to create device node
    RDMA: Add netlink infrastructure
    RDMA: Add error handling to ib_core_init()

    Linus Torvalds
     

26 May, 2011

1 commit

  • Add callbacks and data types for statistics export of all current
    devices/ids. The schema for RDMA CM is a series of netlink messages.
    Each one contains an rdma_cm_stat struct. Additionally, two netlink
    attributes are created for the addresses for each message (if
    applicable).

    Their types used are:
    RDMA_NL_RDMA_CM_ATTR_SRC_ADDR (The source address for this ID)
    RDMA_NL_RDMA_CM_ATTR_DST_ADDR (The destination address for this ID)
    sockaddr_* structs are encapsulated within these attributes.

    In other words, every transaction contains a series of messages like:

    -------message 1-------
    struct rdma_cm_id_stats {
    __u32 qp_num;
    __u32 bound_dev_if;
    __u32 port_space;
    __s32 pid;
    __u8 cm_state;
    __u8 node_type;
    __u8 port_num;
    __u8 reserved;
    }
    RDMA_NL_RDMA_CM_ATTR_SRC_ADDR attribute - contains the source address
    RDMA_NL_RDMA_CM_ATTR_DST_ADDR attribute - contains the destination address
    -------end 1-------
    -------message 2-------
    struct rdma_cm_id_stats
    RDMA_NL_RDMA_CM_ATTR_SRC_ADDR attribute
    RDMA_NL_RDMA_CM_ATTR_DST_ADDR attribute
    -------end 2-------

    Signed-off-by: Nir Muchtar
    Signed-off-by: Roland Dreier

    Nir Muchtar