30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

12 Nov, 2009

1 commit

  • For MPC8569 CPUs we'll need to reset QE after each suspend, so make
    qe_reset() code path suitable for repeated invocation, that is:

    - Don't initialize rheap structures if already initialized;
    - Don't allocate muram for SDMA if already allocated, just reinitialize
    registers with previously allocated muram offset;
    - Remove __init attributes from qe_reset() and cpm_muram_init();

    Signed-off-by: Anton Vorontsov
    Signed-off-by: Kumar Gala

    Anton Vorontsov
     

24 Mar, 2009

1 commit

  • This patch tweaks the way some PTE bit combinations are defined, in such a
    way that the 32 and 64-bit variant become almost identical and that will
    make it easier to bring in a new common pte-* file for the new variant
    of the Book3-E support.

    The combination of bits defining access to kernel pages are now clearly
    separated from the combination used by userspace and the core VM. The
    resulting generated code should remain identical unless I made a mistake.

    Note: While at it, I removed a non-sensical statement related to CONFIG_KGDB
    in ppc_mmu_32.c which could cause kernel mappings to be user accessible when
    that option is enabled. Probably something that bitrot.

    Signed-off-by: Benjamin Herrenschmidt

    Benjamin Herrenschmidt
     

21 Aug, 2008

1 commit


28 Jul, 2008

1 commit


14 Jul, 2008

1 commit


11 Jun, 2008

1 commit

  • This is very trivial patch. We're transitioning to the cpm_muram_*
    calls. That's it.

    Less trivial changes:
    - BD_SC_* defines were defined in the cpm.h and qe.h, so to avoid redefines
    we remove BD_SC from the qe.h and use cpm.h along with cpm_muram_*
    prototypes;
    - qe_muram_dump was unused and thus removed;
    - added some code to the cpm_common.c to support legacy QE bindings
    (data-only node name).
    - For convenience, define qe_* calls to cpm_*. So drivers need not to be
    changed.

    Signed-off-by: Anton Vorontsov
    Signed-off-by: Kumar Gala

    Anton Vorontsov
     

17 Apr, 2008

1 commit


09 Nov, 2007

1 commit


05 Oct, 2007

1 commit

  • The way the current CPM binding describes available multi-user (a.k.a.
    dual-ported) RAM doesn't work well when there are multiple free regions,
    and it doesn't work at all if the region doesn't begin at the start of
    the muram area (as the hardware needs to be programmed with offsets into
    this area). The latter situation can happen with SMC UARTs on CPM2, as its
    parameter RAM is relocatable, u-boot puts it at zero, and the kernel doesn't
    support moving it.

    It is now described with a muram node, similar to QE. The current CPM
    binding is sufficiently recent (i.e. never appeared in an official release)
    that compatibility with existing device trees is not an issue.

    The code supporting the new binding is shared between cpm1 and cpm2, rather
    than remain separated. QE should be able to use this code as well, once
    minor fixes are made to its device trees.

    Signed-off-by: Scott Wood
    Signed-off-by: Kumar Gala

    Scott Wood
     

04 Oct, 2007

1 commit