Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 1f2a144f5ab5e836b5ca8f67bd76b759fa947751

Authored by Stephen Hemminger
Committed by Michal Marek
1 parent b59a122584
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

scripts: improve checkstack 

Cleanup checkstack script:
  * Turn on strict checking
  * Fix resulting error message because the declaration syntax
    was incorrect.
  * Remove incorrect and misleading use of prototype
     - prototype not required for this type of sort function
       because $a and $b are being used in this contex
     - if prototype was being used it should be for both arguments
  * Use closure for sort function

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Cong Wang <amwang@redhat.com>
Cc: Michal Marek <mmarek@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>

Showing 1 changed file with 6 additions and 10 deletions Inline Diff

scripts/checkstack.pl
Diff comments   View file @ 1f2a144
1 #!/usr/bin/perl 1 #!/usr/bin/perl
2 2
3 # Check the stack usage of functions 3 # Check the stack usage of functions
4 # 4 #
5 # Copyright Joern Engel <joern@lazybastard.org> 5 # Copyright Joern Engel <joern@lazybastard.org>
6 # Inspired by Linus Torvalds 6 # Inspired by Linus Torvalds
7 # Original idea maybe from Keith Owens 7 # Original idea maybe from Keith Owens
8 # s390 port and big speedup by Arnd Bergmann <arnd@bergmann-dalldorf.de> 8 # s390 port and big speedup by Arnd Bergmann <arnd@bergmann-dalldorf.de>
9 # Mips port by Juan Quintela <quintela@mandrakesoft.com> 9 # Mips port by Juan Quintela <quintela@mandrakesoft.com>
10 # IA64 port via Andreas Dilger 10 # IA64 port via Andreas Dilger
11 # Arm port by Holger Schurig 11 # Arm port by Holger Schurig
12 # sh64 port by Paul Mundt 12 # sh64 port by Paul Mundt
13 # Random bits by Matt Mackall <mpm@selenic.com> 13 # Random bits by Matt Mackall <mpm@selenic.com>
14 # M68k port by Geert Uytterhoeven and Andreas Schwab 14 # M68k port by Geert Uytterhoeven and Andreas Schwab
15 # AVR32 port by Haavard Skinnemoen <hskinnemoen@atmel.com> 15 # AVR32 port by Haavard Skinnemoen <hskinnemoen@atmel.com>
16 # PARISC port by Kyle McMartin <kyle@parisc-linux.org> 16 # PARISC port by Kyle McMartin <kyle@parisc-linux.org>
17 # sparc port by Martin Habets <errandir_news@mph.eclipse.co.uk> 17 # sparc port by Martin Habets <errandir_news@mph.eclipse.co.uk>
18 # 18 #
19 # Usage: 19 # Usage:
20 # objdump -d vmlinux | scripts/checkstack.pl [arch] 20 # objdump -d vmlinux | scripts/checkstack.pl [arch]
21 # 21 #
22 # TODO : Port to all architectures (one regex per arch) 22 # TODO : Port to all architectures (one regex per arch)
23 23
24 use strict;
25
24 # check for arch 26 # check for arch
25 # 27 #
26 # $re is used for two matches: 28 # $re is used for two matches:
27 # $& (whole re) matches the complete objdump line with the stack growth 29 # $& (whole re) matches the complete objdump line with the stack growth
28 # $1 (first bracket) matches the size of the stack growth 30 # $1 (first bracket) matches the size of the stack growth
29 # 31 #
30 # $dre is similar, but for dynamic stack redutions: 32 # $dre is similar, but for dynamic stack redutions:
31 # $& (whole re) matches the complete objdump line with the stack growth 33 # $& (whole re) matches the complete objdump line with the stack growth
32 # $1 (first bracket) matches the dynamic amount of the stack growth 34 # $1 (first bracket) matches the dynamic amount of the stack growth
33 # 35 #
34 # use anything else and feel the pain ;) 36 # use anything else and feel the pain ;)
35 my (@stack, $re, $dre, $x, $xs); 37 my (@stack, $re, $dre, $x, $xs);
36 { 38 {
37 my $arch = shift; 39 my $arch = shift;
38 if ($arch eq "") { 40 if ($arch eq "") {
39 $arch = `uname -m`; 41 $arch = `uname -m`;
40 chomp($arch); 42 chomp($arch);
41 } 43 }
42 44
43 $x = "[0-9a-f]"; # hex character 45 $x = "[0-9a-f]"; # hex character
44 $xs = "[0-9a-f ]"; # hex character or space 46 $xs = "[0-9a-f ]"; # hex character or space
45 if ($arch eq 'arm') { 47 if ($arch eq 'arm') {
46 #c0008ffc: e24dd064 sub sp, sp, #100 ; 0x64 48 #c0008ffc: e24dd064 sub sp, sp, #100 ; 0x64
47 $re = qr/.*sub.*sp, sp, #(([0-9]{2}|[3-9])[0-9]{2})/o; 49 $re = qr/.*sub.*sp, sp, #(([0-9]{2}|[3-9])[0-9]{2})/o;
48 } elsif ($arch eq 'avr32') { 50 } elsif ($arch eq 'avr32') {
49 #8000008a: 20 1d sub sp,4 51 #8000008a: 20 1d sub sp,4
50 #80000ca8: fa cd 05 b0 sub sp,sp,1456 52 #80000ca8: fa cd 05 b0 sub sp,sp,1456
51 $re = qr/^.*sub.*sp.*,([0-9]{1,8})/o; 53 $re = qr/^.*sub.*sp.*,([0-9]{1,8})/o;
52 } elsif ($arch =~ /^i[3456]86$/) { 54 } elsif ($arch =~ /^i[3456]86$/) {
53 #c0105234: 81 ec ac 05 00 00 sub $0x5ac,%esp 55 #c0105234: 81 ec ac 05 00 00 sub $0x5ac,%esp
54 $re = qr/^.*[as][du][db] \$(0x$x{1,8}),\%esp$/o; 56 $re = qr/^.*[as][du][db] \$(0x$x{1,8}),\%esp$/o;
55 $dre = qr/^.*[as][du][db] (%.*),\%esp$/o; 57 $dre = qr/^.*[as][du][db] (%.*),\%esp$/o;
56 } elsif ($arch eq 'x86_64') { 58 } elsif ($arch eq 'x86_64') {
57 # 2f60: 48 81 ec e8 05 00 00 sub $0x5e8,%rsp 59 # 2f60: 48 81 ec e8 05 00 00 sub $0x5e8,%rsp
58 $re = qr/^.*[as][du][db] \$(0x$x{1,8}),\%rsp$/o; 60 $re = qr/^.*[as][du][db] \$(0x$x{1,8}),\%rsp$/o;
59 $dre = qr/^.*[as][du][db] (\%.*),\%rsp$/o; 61 $dre = qr/^.*[as][du][db] (\%.*),\%rsp$/o;
60 } elsif ($arch eq 'ia64') { 62 } elsif ($arch eq 'ia64') {
61 #e0000000044011fc: 01 0f fc 8c adds r12=-384,r12 63 #e0000000044011fc: 01 0f fc 8c adds r12=-384,r12
62 $re = qr/.*adds.*r12=-(([0-9]{2}|[3-9])[0-9]{2}),r12/o; 64 $re = qr/.*adds.*r12=-(([0-9]{2}|[3-9])[0-9]{2}),r12/o;
63 } elsif ($arch eq 'm68k') { 65 } elsif ($arch eq 'm68k') {
64 # 2b6c: 4e56 fb70 linkw %fp,#-1168 66 # 2b6c: 4e56 fb70 linkw %fp,#-1168
65 # 1df770: defc ffe4 addaw #-28,%sp 67 # 1df770: defc ffe4 addaw #-28,%sp
66 $re = qr/.*(?:linkw %fp,|addaw )#-([0-9]{1,4})(?:,%sp)?$/o; 68 $re = qr/.*(?:linkw %fp,|addaw )#-([0-9]{1,4})(?:,%sp)?$/o;
67 } elsif ($arch eq 'mips64') { 69 } elsif ($arch eq 'mips64') {
68 #8800402c: 67bdfff0 daddiu sp,sp,-16 70 #8800402c: 67bdfff0 daddiu sp,sp,-16
69 $re = qr/.*daddiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o; 71 $re = qr/.*daddiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o;
70 } elsif ($arch eq 'mips') { 72 } elsif ($arch eq 'mips') {
71 #88003254: 27bdffe0 addiu sp,sp,-32 73 #88003254: 27bdffe0 addiu sp,sp,-32
72 $re = qr/.*addiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o; 74 $re = qr/.*addiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o;
73 } elsif ($arch eq 'parisc' || $arch eq 'parisc64') { 75 } elsif ($arch eq 'parisc' || $arch eq 'parisc64') {
74 $re = qr/.*ldo ($x{1,8})\(sp\),sp/o; 76 $re = qr/.*ldo ($x{1,8})\(sp\),sp/o;
75 } elsif ($arch eq 'ppc') { 77 } elsif ($arch eq 'ppc') {
76 #c00029f4: 94 21 ff 30 stwu r1,-208(r1) 78 #c00029f4: 94 21 ff 30 stwu r1,-208(r1)
77 $re = qr/.*stwu.*r1,-($x{1,8})\(r1\)/o; 79 $re = qr/.*stwu.*r1,-($x{1,8})\(r1\)/o;
78 } elsif ($arch eq 'ppc64') { 80 } elsif ($arch eq 'ppc64') {
79 #XXX 81 #XXX
80 $re = qr/.*stdu.*r1,-($x{1,8})\(r1\)/o; 82 $re = qr/.*stdu.*r1,-($x{1,8})\(r1\)/o;
81 } elsif ($arch eq 'powerpc') { 83 } elsif ($arch eq 'powerpc') {
82 $re = qr/.*st[dw]u.*r1,-($x{1,8})\(r1\)/o; 84 $re = qr/.*st[dw]u.*r1,-($x{1,8})\(r1\)/o;
83 } elsif ($arch =~ /^s390x?$/) { 85 } elsif ($arch =~ /^s390x?$/) {
84 # 11160: a7 fb ff 60 aghi %r15,-160 86 # 11160: a7 fb ff 60 aghi %r15,-160
85 # or 87 # or
86 # 100092: e3 f0 ff c8 ff 71 lay %r15,-56(%r15) 88 # 100092: e3 f0 ff c8 ff 71 lay %r15,-56(%r15)
87 $re = qr/.*(?:lay|ag?hi).*\%r15,-(([0-9]{2}|[3-9])[0-9]{2}) 89 $re = qr/.*(?:lay|ag?hi).*\%r15,-(([0-9]{2}|[3-9])[0-9]{2})
88 (?:\(\%r15\))?$/ox; 90 (?:\(\%r15\))?$/ox;
89 } elsif ($arch =~ /^sh64$/) { 91 } elsif ($arch =~ /^sh64$/) {
90 #XXX: we only check for the immediate case presently, 92 #XXX: we only check for the immediate case presently,
91 # though we will want to check for the movi/sub 93 # though we will want to check for the movi/sub
92 # pair for larger users. -- PFM. 94 # pair for larger users. -- PFM.
93 #a00048e0: d4fc40f0 addi.l r15,-240,r15 95 #a00048e0: d4fc40f0 addi.l r15,-240,r15
94 $re = qr/.*addi\.l.*r15,-(([0-9]{2}|[3-9])[0-9]{2}),r15/o; 96 $re = qr/.*addi\.l.*r15,-(([0-9]{2}|[3-9])[0-9]{2}),r15/o;
95 } elsif ($arch =~ /^blackfin$/) { 97 } elsif ($arch =~ /^blackfin$/) {
96 # 0: 00 e8 38 01 LINK 0x4e0; 98 # 0: 00 e8 38 01 LINK 0x4e0;
97 $re = qr/.*[[:space:]]LINK[[:space:]]*(0x$x{1,8})/o; 99 $re = qr/.*[[:space:]]LINK[[:space:]]*(0x$x{1,8})/o;
98 } elsif ($arch eq 'sparc' || $arch eq 'sparc64') { 100 } elsif ($arch eq 'sparc' || $arch eq 'sparc64') {
99 # f0019d10: 9d e3 bf 90 save %sp, -112, %sp 101 # f0019d10: 9d e3 bf 90 save %sp, -112, %sp
100 $re = qr/.*save.*%sp, -(([0-9]{2}|[3-9])[0-9]{2}), %sp/o; 102 $re = qr/.*save.*%sp, -(([0-9]{2}|[3-9])[0-9]{2}), %sp/o;
101 } else { 103 } else {
102 print("wrong or unknown architecture \"$arch\"\n"); 104 print("wrong or unknown architecture \"$arch\"\n");
103 exit 105 exit
104 } 106 }
105 } 107 }
106 108
107 sub bysize($) {
108 my ($asize, $bsize);
109 ($asize = $a) =~ s/.*: *(.*)$/$1/;
110 ($bsize = $b) =~ s/.*: *(.*)$/$1/;
111 $bsize <=> $asize
112 }
113
114 # 109 #
115 # main() 110 # main()
116 # 111 #
117 my $funcre = qr/^$x* <(.*)>:$/; 112 my $funcre = qr/^$x* <(.*)>:$/;
118 my $func; 113 my ($func, $file, $lastslash);
119 my $file, $lastslash;
120 114
121 while (my $line = <STDIN>) { 115 while (my $line = <STDIN>) {
122 if ($line =~ m/$funcre/) { 116 if ($line =~ m/$funcre/) {
123 $func = $1; 117 $func = $1;
124 } 118 }
125 elsif ($line =~ m/(.*):\s*file format/) { 119 elsif ($line =~ m/(.*):\s*file format/) {
126 $file = $1; 120 $file = $1;
127 $file =~ s/\.ko//; 121 $file =~ s/\.ko//;
128 $lastslash = rindex($file, "/"); 122 $lastslash = rindex($file, "/");
129 if ($lastslash != -1) { 123 if ($lastslash != -1) {
130 $file = substr($file, $lastslash + 1); 124 $file = substr($file, $lastslash + 1);
131 } 125 }
132 } 126 }
133 elsif ($line =~ m/$re/) { 127 elsif ($line =~ m/$re/) {
134 my $size = $1; 128 my $size = $1;
135 $size = hex($size) if ($size =~ /^0x/); 129 $size = hex($size) if ($size =~ /^0x/);
136 130
137 if ($size > 0xf0000000) { 131 if ($size > 0xf0000000) {
138 $size = - $size; 132 $size = - $size;
139 $size += 0x80000000; 133 $size += 0x80000000;
140 $size += 0x80000000; 134 $size += 0x80000000;
141 } 135 }
142 next if ($size > 0x10000000); 136 next if ($size > 0x10000000);
143 137
144 next if $line !~ m/^($xs*)/; 138 next if $line !~ m/^($xs*)/;
145 my $addr = $1; 139 my $addr = $1;
146 $addr =~ s/ /0/g; 140 $addr =~ s/ /0/g;
147 $addr = "0x$addr"; 141 $addr = "0x$addr";
148 142
149 my $intro = "$addr $func [$file]:"; 143 my $intro = "$addr $func [$file]:";
150 my $padlen = 56 - length($intro); 144 my $padlen = 56 - length($intro);
151 while ($padlen > 0) { 145 while ($padlen > 0) {
152 $intro .= ' '; 146 $intro .= ' ';
153 $padlen -= 8; 147 $padlen -= 8;
154 } 148 }
155 next if ($size < 100); 149 next if ($size < 100);
156 push @stack, "$intro$size\n"; 150 push @stack, "$intro$size\n";
157 } 151 }
158 elsif (defined $dre && $line =~ m/$dre/) { 152 elsif (defined $dre && $line =~ m/$dre/) {
159 my $size = "Dynamic ($1)"; 153 my $size = "Dynamic ($1)";
160 154
161 next if $line !~ m/^($xs*)/; 155 next if $line !~ m/^($xs*)/;
162 my $addr = $1; 156 my $addr = $1;
163 $addr =~ s/ /0/g; 157 $addr =~ s/ /0/g;
164 $addr = "0x$addr"; 158 $addr = "0x$addr";
165 159
166 my $intro = "$addr $func [$file]:"; 160 my $intro = "$addr $func [$file]:";
167 my $padlen = 56 - length($intro); 161 my $padlen = 56 - length($intro);
168 while ($padlen > 0) { 162 while ($padlen > 0) {
169 $intro .= ' '; 163 $intro .= ' ';
170 $padlen -= 8; 164 $padlen -= 8;
171 } 165 }
172 push @stack, "$intro$size\n"; 166 push @stack, "$intro$size\n";
173 } 167 }
174 } 168 }
175 169