Blame view

security/apparmor/policy_unpack.c 19 KB
736ec752d   John Johansen   AppArmor: policy ...
1
2
3
4
5
6
7
8
9
10
11
12
13
14
  /*
   * AppArmor security module
   *
   * This file contains AppArmor functions for unpacking policy loaded from
   * userspace.
   *
   * Copyright (C) 1998-2008 Novell/SUSE
   * Copyright 2009-2010 Canonical Ltd.
   *
   * This program is free software; you can redistribute it and/or
   * modify it under the terms of the GNU General Public License as
   * published by the Free Software Foundation, version 2 of the
   * License.
   *
d410fa4ef   Randy Dunlap   Create Documentat...
15
16
   * AppArmor uses a serialized binary format for loading policy. To find
   * policy format documentation look in Documentation/security/apparmor.txt
736ec752d   John Johansen   AppArmor: policy ...
17
18
19
20
21
22
23
24
25
26
   * All policy is validated before it is used.
   */
  
  #include <asm/unaligned.h>
  #include <linux/ctype.h>
  #include <linux/errno.h>
  
  #include "include/apparmor.h"
  #include "include/audit.h"
  #include "include/context.h"
f8eb8a132   John Johansen   apparmor: add the...
27
  #include "include/crypto.h"
736ec752d   John Johansen   AppArmor: policy ...
28
29
30
  #include "include/match.h"
  #include "include/policy.h"
  #include "include/policy_unpack.h"
736ec752d   John Johansen   AppArmor: policy ...
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
  
  /*
   * The AppArmor interface treats data as a type byte followed by the
   * actual data.  The interface has the notion of a a named entry
   * which has a name (AA_NAME typecode followed by name string) followed by
   * the entries typecode and data.  Named types allow for optional
   * elements and extensions to be added and tested for without breaking
   * backwards compatibility.
   */
  
  enum aa_code {
  	AA_U8,
  	AA_U16,
  	AA_U32,
  	AA_U64,
  	AA_NAME,		/* same as string except it is items name */
  	AA_STRING,
  	AA_BLOB,
  	AA_STRUCT,
  	AA_STRUCTEND,
  	AA_LIST,
  	AA_LISTEND,
  	AA_ARRAY,
  	AA_ARRAYEND,
  };
  
  /*
   * aa_ext is the read of the buffer containing the serialized profile.  The
   * data is copied into a kernel buffer in apparmorfs and then handed off to
   * the unpack routines.
   */
  struct aa_ext {
  	void *start;
  	void *end;
  	void *pos;		/* pointer to current position in the buffer */
  	u32 version;
  };
  
  /* audit callback for unpack fields */
  static void audit_cb(struct audit_buffer *ab, void *va)
  {
  	struct common_audit_data *sa = va;
3b3b0e4fc   Eric Paris   LSM: shrink sizeo...
73
74
  	if (sa->aad->iface.target) {
  		struct aa_profile *name = sa->aad->iface.target;
736ec752d   John Johansen   AppArmor: policy ...
75
76
77
  		audit_log_format(ab, " name=");
  		audit_log_untrustedstring(ab, name->base.hname);
  	}
3b3b0e4fc   Eric Paris   LSM: shrink sizeo...
78
79
  	if (sa->aad->iface.pos)
  		audit_log_format(ab, " offset=%ld", sa->aad->iface.pos);
736ec752d   John Johansen   AppArmor: policy ...
80
81
82
83
84
85
86
  }
  
  /**
   * audit_iface - do audit message for policy unpacking/load/replace/remove
   * @new: profile if it has been allocated (MAYBE NULL)
   * @name: name of the profile being manipulated (MAYBE NULL)
   * @info: any extra info about the failure (MAYBE NULL)
b1b4bc2ed   John Johansen   AppArmor: Fix oop...
87
   * @e: buffer position info
736ec752d   John Johansen   AppArmor: policy ...
88
89
90
91
92
93
94
95
96
   * @error: error code
   *
   * Returns: %0 or error
   */
  static int audit_iface(struct aa_profile *new, const char *name,
  		       const char *info, struct aa_ext *e, int error)
  {
  	struct aa_profile *profile = __aa_current_profile();
  	struct common_audit_data sa;
3b3b0e4fc   Eric Paris   LSM: shrink sizeo...
97
  	struct apparmor_audit_data aad = {0,};
50c205f5e   Eric Paris   LSM: do not initi...
98
  	sa.type = LSM_AUDIT_DATA_NONE;
3b3b0e4fc   Eric Paris   LSM: shrink sizeo...
99
  	sa.aad = &aad;
b1b4bc2ed   John Johansen   AppArmor: Fix oop...
100
  	if (e)
3b3b0e4fc   Eric Paris   LSM: shrink sizeo...
101
102
103
104
105
  		aad.iface.pos = e->pos - e->start;
  	aad.iface.target = new;
  	aad.name = name;
  	aad.info = info;
  	aad.error = error;
736ec752d   John Johansen   AppArmor: policy ...
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
  
  	return aa_audit(AUDIT_APPARMOR_STATUS, profile, GFP_KERNEL, &sa,
  			audit_cb);
  }
  
  /* test if read will be in packed data bounds */
  static bool inbounds(struct aa_ext *e, size_t size)
  {
  	return (size <= e->end - e->pos);
  }
  
  /**
   * aa_u16_chunck - test and do bounds checking for a u16 size based chunk
   * @e: serialized data read head (NOT NULL)
   * @chunk: start address for chunk of data (NOT NULL)
   *
   * Returns: the size of chunk found with the read head at the end of the chunk.
   */
  static size_t unpack_u16_chunk(struct aa_ext *e, char **chunk)
  {
  	size_t size = 0;
  
  	if (!inbounds(e, sizeof(u16)))
  		return 0;
  	size = le16_to_cpu(get_unaligned((u16 *) e->pos));
  	e->pos += sizeof(u16);
  	if (!inbounds(e, size))
  		return 0;
  	*chunk = e->pos;
  	e->pos += size;
  	return size;
  }
  
  /* unpack control byte */
  static bool unpack_X(struct aa_ext *e, enum aa_code code)
  {
  	if (!inbounds(e, 1))
  		return 0;
  	if (*(u8 *) e->pos != code)
  		return 0;
  	e->pos++;
  	return 1;
  }
  
  /**
   * unpack_nameX - check is the next element is of type X with a name of @name
   * @e: serialized data extent information  (NOT NULL)
   * @code: type code
   * @name: name to match to the serialized element.  (MAYBE NULL)
   *
   * check that the next serialized data element is of type X and has a tag
   * name @name.  If @name is specified then there must be a matching
   * name element in the stream.  If @name is NULL any name element will be
   * skipped and only the typecode will be tested.
   *
   * Returns 1 on success (both type code and name tests match) and the read
   * head is advanced past the headers
   *
   * Returns: 0 if either match fails, the read head does not move
   */
  static bool unpack_nameX(struct aa_ext *e, enum aa_code code, const char *name)
  {
  	/*
  	 * May need to reset pos if name or type doesn't match
  	 */
  	void *pos = e->pos;
  	/*
  	 * Check for presence of a tagname, and if present name size
  	 * AA_NAME tag value is a u16.
  	 */
  	if (unpack_X(e, AA_NAME)) {
  		char *tag = NULL;
  		size_t size = unpack_u16_chunk(e, &tag);
  		/* if a name is specified it must match. otherwise skip tag */
  		if (name && (!size || strcmp(name, tag)))
  			goto fail;
  	} else if (name) {
  		/* if a name is specified and there is no name tag fail */
  		goto fail;
  	}
  
  	/* now check if type code matches */
  	if (unpack_X(e, code))
  		return 1;
  
  fail:
  	e->pos = pos;
  	return 0;
  }
  
  static bool unpack_u32(struct aa_ext *e, u32 *data, const char *name)
  {
  	if (unpack_nameX(e, AA_U32, name)) {
  		if (!inbounds(e, sizeof(u32)))
  			return 0;
  		if (data)
  			*data = le32_to_cpu(get_unaligned((u32 *) e->pos));
  		e->pos += sizeof(u32);
  		return 1;
  	}
  	return 0;
  }
  
  static bool unpack_u64(struct aa_ext *e, u64 *data, const char *name)
  {
  	if (unpack_nameX(e, AA_U64, name)) {
  		if (!inbounds(e, sizeof(u64)))
  			return 0;
  		if (data)
  			*data = le64_to_cpu(get_unaligned((u64 *) e->pos));
  		e->pos += sizeof(u64);
  		return 1;
  	}
  	return 0;
  }
  
  static size_t unpack_array(struct aa_ext *e, const char *name)
  {
  	if (unpack_nameX(e, AA_ARRAY, name)) {
  		int size;
  		if (!inbounds(e, sizeof(u16)))
  			return 0;
  		size = (int)le16_to_cpu(get_unaligned((u16 *) e->pos));
  		e->pos += sizeof(u16);
  		return size;
  	}
  	return 0;
  }
  
  static size_t unpack_blob(struct aa_ext *e, char **blob, const char *name)
  {
  	if (unpack_nameX(e, AA_BLOB, name)) {
  		u32 size;
  		if (!inbounds(e, sizeof(u32)))
  			return 0;
  		size = le32_to_cpu(get_unaligned((u32 *) e->pos));
  		e->pos += sizeof(u32);
  		if (inbounds(e, (size_t) size)) {
  			*blob = e->pos;
  			e->pos += size;
  			return size;
  		}
  	}
  	return 0;
  }
  
  static int unpack_str(struct aa_ext *e, const char **string, const char *name)
  {
  	char *src_str;
  	size_t size = 0;
  	void *pos = e->pos;
  	*string = NULL;
  	if (unpack_nameX(e, AA_STRING, name)) {
  		size = unpack_u16_chunk(e, &src_str);
  		if (size) {
  			/* strings are null terminated, length is size - 1 */
  			if (src_str[size - 1] != 0)
  				goto fail;
  			*string = src_str;
  		}
  	}
  	return size;
  
  fail:
  	e->pos = pos;
  	return 0;
  }
  
  static int unpack_strdup(struct aa_ext *e, char **string, const char *name)
  {
  	const char *tmp;
  	void *pos = e->pos;
  	int res = unpack_str(e, &tmp, name);
  	*string = NULL;
  
  	if (!res)
  		return 0;
  
  	*string = kmemdup(tmp, res, GFP_KERNEL);
  	if (!*string) {
  		e->pos = pos;
  		return 0;
  	}
  
  	return res;
  }
180a6f596   John Johansen   apparmor: move pe...
292
293
  #define DFA_VALID_PERM_MASK		0xffffffff
  #define DFA_VALID_PERM2_MASK		0xffffffff
736ec752d   John Johansen   AppArmor: policy ...
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
  /**
   * verify_accept - verify the accept tables of a dfa
   * @dfa: dfa to verify accept tables of (NOT NULL)
   * @flags: flags governing dfa
   *
   * Returns: 1 if valid accept tables else 0 if error
   */
  static bool verify_accept(struct aa_dfa *dfa, int flags)
  {
  	int i;
  
  	/* verify accept permissions */
  	for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) {
  		int mode = ACCEPT_TABLE(dfa)[i];
  
  		if (mode & ~DFA_VALID_PERM_MASK)
  			return 0;
  
  		if (ACCEPT_TABLE2(dfa)[i] & ~DFA_VALID_PERM2_MASK)
  			return 0;
  	}
  	return 1;
  }
  
  /**
   * unpack_dfa - unpack a file rule dfa
   * @e: serialized data extent information (NOT NULL)
   *
   * returns dfa or ERR_PTR or NULL if no dfa
   */
  static struct aa_dfa *unpack_dfa(struct aa_ext *e)
  {
  	char *blob = NULL;
  	size_t size;
  	struct aa_dfa *dfa = NULL;
  
  	size = unpack_blob(e, &blob, "aadfa");
  	if (size) {
  		/*
  		 * The dfa is aligned with in the blob to 8 bytes
  		 * from the beginning of the stream.
dd51c8485   John Johansen   apparmor: provide...
335
  		 * alignment adjust needed by dfa unpack
736ec752d   John Johansen   AppArmor: policy ...
336
  		 */
dd51c8485   John Johansen   apparmor: provide...
337
338
  		size_t sz = blob - (char *) e->start -
  			((e->pos - e->start) & 7);
736ec752d   John Johansen   AppArmor: policy ...
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
  		size_t pad = ALIGN(sz, 8) - sz;
  		int flags = TO_ACCEPT1_FLAG(YYTD_DATA32) |
  			TO_ACCEPT2_FLAG(YYTD_DATA32);
  
  
  		if (aa_g_paranoid_load)
  			flags |= DFA_FLAG_VERIFY_STATES;
  
  		dfa = aa_dfa_unpack(blob + pad, size - pad, flags);
  
  		if (IS_ERR(dfa))
  			return dfa;
  
  		if (!verify_accept(dfa, flags))
  			goto fail;
  	}
  
  	return dfa;
  
  fail:
  	aa_put_dfa(dfa);
  	return ERR_PTR(-EPROTO);
  }
  
  /**
   * unpack_trans_table - unpack a profile transition table
   * @e: serialized data extent information  (NOT NULL)
   * @profile: profile to add the accept table to (NOT NULL)
   *
25985edce   Lucas De Marchi   Fix common misspe...
368
   * Returns: 1 if table successfully unpacked
736ec752d   John Johansen   AppArmor: policy ...
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
   */
  static bool unpack_trans_table(struct aa_ext *e, struct aa_profile *profile)
  {
  	void *pos = e->pos;
  
  	/* exec table is optional */
  	if (unpack_nameX(e, AA_STRUCT, "xtable")) {
  		int i, size;
  
  		size = unpack_array(e, NULL);
  		/* currently 4 exec bits and entries 0-3 are reserved iupcx */
  		if (size > 16 - 4)
  			goto fail;
  		profile->file.trans.table = kzalloc(sizeof(char *) * size,
  						    GFP_KERNEL);
  		if (!profile->file.trans.table)
  			goto fail;
  
  		profile->file.trans.size = size;
  		for (i = 0; i < size; i++) {
  			char *str;
7ee95850b   James Morris   apparmor: sparse ...
390
  			int c, j, size2 = unpack_strdup(e, &str, NULL);
736ec752d   John Johansen   AppArmor: policy ...
391
392
393
  			/* unpack_strdup verifies that the last character is
  			 * null termination byte.
  			 */
7ee95850b   James Morris   apparmor: sparse ...
394
  			if (!size2)
736ec752d   John Johansen   AppArmor: policy ...
395
396
397
398
399
400
401
  				goto fail;
  			profile->file.trans.table[i] = str;
  			/* verify that name doesn't start with space */
  			if (isspace(*str))
  				goto fail;
  
  			/* count internal #  of internal \0 */
7ee95850b   James Morris   apparmor: sparse ...
402
  			for (c = j = 0; j < size2 - 2; j++) {
736ec752d   John Johansen   AppArmor: policy ...
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
  				if (!str[j])
  					c++;
  			}
  			if (*str == ':') {
  				/* beginning with : requires an embedded \0,
  				 * verify that exactly 1 internal \0 exists
  				 * trailing \0 already verified by unpack_strdup
  				 */
  				if (c != 1)
  					goto fail;
  				/* first character after : must be valid */
  				if (!str[1])
  					goto fail;
  			} else if (c)
  				/* fail - all other cases with embedded \0 */
  				goto fail;
  		}
  		if (!unpack_nameX(e, AA_ARRAYEND, NULL))
  			goto fail;
  		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
  			goto fail;
  	}
  	return 1;
  
  fail:
  	aa_free_domain_entries(&profile->file.trans);
  	e->pos = pos;
  	return 0;
  }
  
  static bool unpack_rlimits(struct aa_ext *e, struct aa_profile *profile)
  {
  	void *pos = e->pos;
  
  	/* rlimits are optional */
  	if (unpack_nameX(e, AA_STRUCT, "rlimits")) {
  		int i, size;
  		u32 tmp = 0;
  		if (!unpack_u32(e, &tmp, NULL))
  			goto fail;
  		profile->rlimits.mask = tmp;
  
  		size = unpack_array(e, NULL);
  		if (size > RLIM_NLIMITS)
  			goto fail;
  		for (i = 0; i < size; i++) {
7ee95850b   James Morris   apparmor: sparse ...
449
  			u64 tmp2 = 0;
736ec752d   John Johansen   AppArmor: policy ...
450
  			int a = aa_map_resource(i);
7ee95850b   James Morris   apparmor: sparse ...
451
  			if (!unpack_u64(e, &tmp2, NULL))
736ec752d   John Johansen   AppArmor: policy ...
452
  				goto fail;
7ee95850b   James Morris   apparmor: sparse ...
453
  			profile->rlimits.limits[a].rlim_max = tmp2;
736ec752d   John Johansen   AppArmor: policy ...
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
  		}
  		if (!unpack_nameX(e, AA_ARRAYEND, NULL))
  			goto fail;
  		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
  			goto fail;
  	}
  	return 1;
  
  fail:
  	e->pos = pos;
  	return 0;
  }
  
  /**
   * unpack_profile - unpack a serialized profile
   * @e: serialized data extent information (NOT NULL)
   *
   * NOTE: unpack profile sets audit struct if there is a failure
   */
  static struct aa_profile *unpack_profile(struct aa_ext *e)
  {
  	struct aa_profile *profile = NULL;
  	const char *name = NULL;
ad5ff3db5   John Johansen   AppArmor: Add abi...
477
  	int i, error = -EPROTO;
736ec752d   John Johansen   AppArmor: policy ...
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
  	kernel_cap_t tmpcap;
  	u32 tmp;
  
  	/* check that we have the right struct being passed */
  	if (!unpack_nameX(e, AA_STRUCT, "profile"))
  		goto fail;
  	if (!unpack_str(e, &name, NULL))
  		goto fail;
  
  	profile = aa_alloc_profile(name);
  	if (!profile)
  		return ERR_PTR(-ENOMEM);
  
  	/* profile renaming is optional */
  	(void) unpack_str(e, &profile->rename, "rename");
556d0be74   John Johansen   apparmor: add an ...
493
494
  	/* attachment string is optional */
  	(void) unpack_str(e, &profile->attach, "attach");
736ec752d   John Johansen   AppArmor: policy ...
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
  	/* xmatch is optional and may be NULL */
  	profile->xmatch = unpack_dfa(e);
  	if (IS_ERR(profile->xmatch)) {
  		error = PTR_ERR(profile->xmatch);
  		profile->xmatch = NULL;
  		goto fail;
  	}
  	/* xmatch_len is not optional if xmatch is set */
  	if (profile->xmatch) {
  		if (!unpack_u32(e, &tmp, NULL))
  			goto fail;
  		profile->xmatch_len = tmp;
  	}
  
  	/* per profile debug flags (complain, audit) */
  	if (!unpack_nameX(e, AA_STRUCT, "flags"))
  		goto fail;
  	if (!unpack_u32(e, &tmp, NULL))
  		goto fail;
038165070   John Johansen   apparmor: allow s...
514
  	if (tmp & PACKED_FLAG_HAT)
736ec752d   John Johansen   AppArmor: policy ...
515
516
517
  		profile->flags |= PFLAG_HAT;
  	if (!unpack_u32(e, &tmp, NULL))
  		goto fail;
038165070   John Johansen   apparmor: allow s...
518
  	if (tmp == PACKED_MODE_COMPLAIN)
736ec752d   John Johansen   AppArmor: policy ...
519
  		profile->mode = APPARMOR_COMPLAIN;
038165070   John Johansen   apparmor: allow s...
520
521
522
523
  	else if (tmp == PACKED_MODE_KILL)
  		profile->mode = APPARMOR_KILL;
  	else if (tmp == PACKED_MODE_UNCONFINED)
  		profile->mode = APPARMOR_UNCONFINED;
736ec752d   John Johansen   AppArmor: policy ...
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
  	if (!unpack_u32(e, &tmp, NULL))
  		goto fail;
  	if (tmp)
  		profile->audit = AUDIT_ALL;
  
  	if (!unpack_nameX(e, AA_STRUCTEND, NULL))
  		goto fail;
  
  	/* path_flags is optional */
  	if (unpack_u32(e, &profile->path_flags, "path_flags"))
  		profile->path_flags |= profile->flags & PFLAG_MEDIATE_DELETED;
  	else
  		/* set a default value if path_flags field is not present */
  		profile->path_flags = PFLAG_MEDIATE_DELETED;
  
  	if (!unpack_u32(e, &(profile->caps.allow.cap[0]), NULL))
  		goto fail;
  	if (!unpack_u32(e, &(profile->caps.audit.cap[0]), NULL))
  		goto fail;
  	if (!unpack_u32(e, &(profile->caps.quiet.cap[0]), NULL))
  		goto fail;
  	if (!unpack_u32(e, &tmpcap.cap[0], NULL))
  		goto fail;
  
  	if (unpack_nameX(e, AA_STRUCT, "caps64")) {
  		/* optional upper half of 64 bit caps */
  		if (!unpack_u32(e, &(profile->caps.allow.cap[1]), NULL))
  			goto fail;
  		if (!unpack_u32(e, &(profile->caps.audit.cap[1]), NULL))
  			goto fail;
  		if (!unpack_u32(e, &(profile->caps.quiet.cap[1]), NULL))
  			goto fail;
  		if (!unpack_u32(e, &(tmpcap.cap[1]), NULL))
  			goto fail;
  		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
  			goto fail;
  	}
  
  	if (unpack_nameX(e, AA_STRUCT, "capsx")) {
  		/* optional extended caps mediation mask */
  		if (!unpack_u32(e, &(profile->caps.extended.cap[0]), NULL))
  			goto fail;
  		if (!unpack_u32(e, &(profile->caps.extended.cap[1]), NULL))
  			goto fail;
cdbd2884d   John Johansen   AppArmor: Add mis...
568
569
  		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
  			goto fail;
736ec752d   John Johansen   AppArmor: policy ...
570
571
572
573
  	}
  
  	if (!unpack_rlimits(e, profile))
  		goto fail;
ad5ff3db5   John Johansen   AppArmor: Add abi...
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
  	if (unpack_nameX(e, AA_STRUCT, "policydb")) {
  		/* generic policy dfa - optional and may be NULL */
  		profile->policy.dfa = unpack_dfa(e);
  		if (IS_ERR(profile->policy.dfa)) {
  			error = PTR_ERR(profile->policy.dfa);
  			profile->policy.dfa = NULL;
  			goto fail;
  		}
  		if (!unpack_u32(e, &profile->policy.start[0], "start"))
  			/* default start state */
  			profile->policy.start[0] = DFA_START;
  		/* setup class index */
  		for (i = AA_CLASS_FILE; i <= AA_CLASS_LAST; i++) {
  			profile->policy.start[i] =
  				aa_dfa_next(profile->policy.dfa,
  					    profile->policy.start[0],
  					    i);
  		}
  		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
  			goto fail;
  	}
736ec752d   John Johansen   AppArmor: policy ...
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
  	/* get file rules */
  	profile->file.dfa = unpack_dfa(e);
  	if (IS_ERR(profile->file.dfa)) {
  		error = PTR_ERR(profile->file.dfa);
  		profile->file.dfa = NULL;
  		goto fail;
  	}
  
  	if (!unpack_u32(e, &profile->file.start, "dfa_start"))
  		/* default start state */
  		profile->file.start = DFA_START;
  
  	if (!unpack_trans_table(e, profile))
  		goto fail;
  
  	if (!unpack_nameX(e, AA_STRUCTEND, NULL))
  		goto fail;
  
  	return profile;
  
  fail:
  	if (profile)
  		name = NULL;
  	else if (!name)
  		name = "unknown";
  	audit_iface(profile, name, "failed to unpack profile", e, error);
8651e1d65   John Johansen   apparmor: make fr...
621
  	aa_free_profile(profile);
736ec752d   John Johansen   AppArmor: policy ...
622
623
624
625
626
627
628
  
  	return ERR_PTR(error);
  }
  
  /**
   * verify_head - unpack serialized stream header
   * @e: serialized data read head (NOT NULL)
dd51c8485   John Johansen   apparmor: provide...
629
   * @required: whether the header is required or optional
736ec752d   John Johansen   AppArmor: policy ...
630
631
632
633
   * @ns: Returns - namespace if one is specified else NULL (NOT NULL)
   *
   * Returns: error or 0 if header is good
   */
dd51c8485   John Johansen   apparmor: provide...
634
  static int verify_header(struct aa_ext *e, int required, const char **ns)
736ec752d   John Johansen   AppArmor: policy ...
635
636
  {
  	int error = -EPROTONOSUPPORT;
dd51c8485   John Johansen   apparmor: provide...
637
638
  	const char *name = NULL;
  	*ns = NULL;
736ec752d   John Johansen   AppArmor: policy ...
639
640
  	/* get the interface version */
  	if (!unpack_u32(e, &e->version, "version")) {
dd51c8485   John Johansen   apparmor: provide...
641
642
643
644
645
  		if (required) {
  			audit_iface(NULL, NULL, "invalid profile format", e,
  				    error);
  			return error;
  		}
736ec752d   John Johansen   AppArmor: policy ...
646

dd51c8485   John Johansen   apparmor: provide...
647
648
649
650
651
652
  		/* check that the interface version is currently supported */
  		if (e->version != 5) {
  			audit_iface(NULL, NULL, "unsupported interface version",
  				    e, error);
  			return error;
  		}
736ec752d   John Johansen   AppArmor: policy ...
653
  	}
dd51c8485   John Johansen   apparmor: provide...
654

736ec752d   John Johansen   AppArmor: policy ...
655
  	/* read the namespace if present */
dd51c8485   John Johansen   apparmor: provide...
656
657
658
659
660
661
  	if (unpack_str(e, &name, "namespace")) {
  		if (*ns && strcmp(*ns, name))
  			audit_iface(NULL, NULL, "invalid ns change", e, error);
  		else if (!*ns)
  			*ns = name;
  	}
736ec752d   John Johansen   AppArmor: policy ...
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
  
  	return 0;
  }
  
  static bool verify_xindex(int xindex, int table_size)
  {
  	int index, xtype;
  	xtype = xindex & AA_X_TYPE_MASK;
  	index = xindex & AA_X_INDEX_MASK;
  	if (xtype == AA_X_TABLE && index > table_size)
  		return 0;
  	return 1;
  }
  
  /* verify dfa xindexes are in range of transition tables */
  static bool verify_dfa_xindex(struct aa_dfa *dfa, int table_size)
  {
  	int i;
  	for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) {
  		if (!verify_xindex(dfa_user_xindex(dfa, i), table_size))
  			return 0;
  		if (!verify_xindex(dfa_other_xindex(dfa, i), table_size))
  			return 0;
  	}
  	return 1;
  }
  
  /**
   * verify_profile - Do post unpack analysis to verify profile consistency
   * @profile: profile to verify (NOT NULL)
   *
   * Returns: 0 if passes verification else error
   */
  static int verify_profile(struct aa_profile *profile)
  {
  	if (aa_g_paranoid_load) {
  		if (profile->file.dfa &&
  		    !verify_dfa_xindex(profile->file.dfa,
  				       profile->file.trans.size)) {
  			audit_iface(profile, NULL, "Invalid named transition",
  				    NULL, -EPROTO);
  			return -EPROTO;
  		}
  	}
  
  	return 0;
  }
dd51c8485   John Johansen   apparmor: provide...
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
  void aa_load_ent_free(struct aa_load_ent *ent)
  {
  	if (ent) {
  		aa_put_profile(ent->rename);
  		aa_put_profile(ent->old);
  		aa_put_profile(ent->new);
  		kzfree(ent);
  	}
  }
  
  struct aa_load_ent *aa_load_ent_alloc(void)
  {
  	struct aa_load_ent *ent = kzalloc(sizeof(*ent), GFP_KERNEL);
  	if (ent)
  		INIT_LIST_HEAD(&ent->list);
  	return ent;
  }
736ec752d   John Johansen   AppArmor: policy ...
726
  /**
dd51c8485   John Johansen   apparmor: provide...
727
   * aa_unpack - unpack packed binary profile(s) data loaded from user space
736ec752d   John Johansen   AppArmor: policy ...
728
729
   * @udata: user data copied to kmem  (NOT NULL)
   * @size: the size of the user data
dd51c8485   John Johansen   apparmor: provide...
730
   * @lh: list to place unpacked profiles in a aa_repl_ws
736ec752d   John Johansen   AppArmor: policy ...
731
732
   * @ns: Returns namespace profile is in if specified else NULL (NOT NULL)
   *
dd51c8485   John Johansen   apparmor: provide...
733
734
735
   * Unpack user data and return refcounted allocated profile(s) stored in
   * @lh in order of discovery, with the list chain stored in base.list
   * or error
736ec752d   John Johansen   AppArmor: policy ...
736
   *
dd51c8485   John Johansen   apparmor: provide...
737
   * Returns: profile(s) on @lh else error pointer if fails to unpack
736ec752d   John Johansen   AppArmor: policy ...
738
   */
dd51c8485   John Johansen   apparmor: provide...
739
  int aa_unpack(void *udata, size_t size, struct list_head *lh, const char **ns)
736ec752d   John Johansen   AppArmor: policy ...
740
  {
dd51c8485   John Johansen   apparmor: provide...
741
  	struct aa_load_ent *tmp, *ent;
736ec752d   John Johansen   AppArmor: policy ...
742
743
744
745
746
747
748
  	struct aa_profile *profile = NULL;
  	int error;
  	struct aa_ext e = {
  		.start = udata,
  		.end = udata + size,
  		.pos = udata,
  	};
dd51c8485   John Johansen   apparmor: provide...
749
750
  	*ns = NULL;
  	while (e.pos < e.end) {
f8eb8a132   John Johansen   apparmor: add the...
751
  		void *start;
dd51c8485   John Johansen   apparmor: provide...
752
753
754
  		error = verify_header(&e, e.pos == e.start, ns);
  		if (error)
  			goto fail;
736ec752d   John Johansen   AppArmor: policy ...
755

f8eb8a132   John Johansen   apparmor: add the...
756
  		start = e.pos;
dd51c8485   John Johansen   apparmor: provide...
757
758
759
760
761
762
763
  		profile = unpack_profile(&e);
  		if (IS_ERR(profile)) {
  			error = PTR_ERR(profile);
  			goto fail;
  		}
  
  		error = verify_profile(profile);
f8eb8a132   John Johansen   apparmor: add the...
764
765
766
767
768
769
770
  		if (error)
  			goto fail_profile;
  
  		error = aa_calc_profile_hash(profile, e.version, start,
  					     e.pos - start);
  		if (error)
  			goto fail_profile;
dd51c8485   John Johansen   apparmor: provide...
771
772
773
774
  
  		ent = aa_load_ent_alloc();
  		if (!ent) {
  			error = -ENOMEM;
f8eb8a132   John Johansen   apparmor: add the...
775
  			goto fail_profile;
dd51c8485   John Johansen   apparmor: provide...
776
  		}
736ec752d   John Johansen   AppArmor: policy ...
777

dd51c8485   John Johansen   apparmor: provide...
778
779
  		ent->new = profile;
  		list_add_tail(&ent->list, lh);
736ec752d   John Johansen   AppArmor: policy ...
780
  	}
dd51c8485   John Johansen   apparmor: provide...
781
  	return 0;
f8eb8a132   John Johansen   apparmor: add the...
782
783
  fail_profile:
  	aa_put_profile(profile);
dd51c8485   John Johansen   apparmor: provide...
784
785
786
787
788
789
790
  fail:
  	list_for_each_entry_safe(ent, tmp, lh, list) {
  		list_del_init(&ent->list);
  		aa_load_ent_free(ent);
  	}
  
  	return error;
736ec752d   John Johansen   AppArmor: policy ...
791
  }