Eric Lee / smarc-fsl-linux-kernel

Commit 020862648445d7c1b12ea213c152f27def703f3b

Authored by David Daney 15 years ago

Committed by Grant Likely 15 years ago

Exists in master and in 39 other branches

of/i2c: Fix request module by alias

If we are registering an i2c device that has a device tree node like
this real-world example:

      rtc@68 {
        compatible = "dallas,ds1337";
        reg = <0x68>;
      };

of_i2c_register_devices() will try to load a module called ds1337.ko.
There is no such module, so it will fail.  If we look in modules.alias
we will find entries like these:

.
.
.
alias i2c:ds1339 rtc_ds1307
alias i2c:ds1338 rtc_ds1307
alias i2c:ds1337 rtc_ds1307
alias i2c:ds1307 rtc_ds1307
alias i2c:ds1374 rtc_ds1374
.
.
.

The module we want is really called rtc_ds1307.ko.  If we request a
module called "i2c:ds1337", the userspace module loader will do the
right thing (unless it is busybox) and load rtc_ds1307.ko.  So we add
the I2C_MODULE_PREFIX to the request_module() string.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/of/of_i2c.c

drivers/of/of_i2c.c

Diff comments View file @ 0208626

...	...	@@ -61,7 +61,7 @@
61	61	info.of_node = of_node_get(node);
62	62	info.archdata = &dev_ad;
63	63
64		- request_module("%s", info.type);
	64	+ request_module("%s%s", I2C_MODULE_PREFIX, info.type);
65	65
66	66	result = i2c_new_device(adap, &info);
67	67	if (result == NULL) {