Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 03221702608c60b470fc86a23bdf4bc30e5bd59f

Authored by Brian Pomerantz
Committed by Linus Torvalds
1 parent 2400ff77e7
Exists in master and in 39 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

[PATCH] fix page leak during core dump 

When the dump cannot occur most likely because of a full file system and
the page to be written is the zero page, the call to page_cache_release()
is missed.

Signed-off-by: Brian Pomerantz <bapper@mvista.com>
Cc: Hugh Dickins <hugh@veritas.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: David Howells <dhowells@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 2 changed files with 5 additions and 2 deletions Side-by-side Diff

... ... @@ -1704,7 +1704,10 @@
1704 1704 DUMP_SEEK(PAGE_SIZE);
1705 1705 } else {
1706 1706 if (page == ZERO_PAGE(addr)) {
1707   - DUMP_SEEK(PAGE_SIZE);
  1707 + if (!dump_seek(file, PAGE_SIZE)) {
  1708 + page_cache_release(page);
  1709 + goto end_coredump;
  1710 + }
1708 1711 } else {
1709 1712 void *kaddr;
1710 1713 flush_cache_page(vma, addr,
fs/binfmt_elf_fdpic.c
Diff comments   View file @ 0322170
... ... @@ -1480,8 +1480,8 @@
1480 1480 DUMP_SEEK(file->f_pos + PAGE_SIZE);
1481 1481 }
1482 1482 else if (page == ZERO_PAGE(addr)) {
1483   - DUMP_SEEK(file->f_pos + PAGE_SIZE);
1484 1483 page_cache_release(page);
  1484 + DUMP_SEEK(file->f_pos + PAGE_SIZE);
1485 1485 }
1486 1486 else {
1487 1487 void *kaddr;