Commit 05f94c60f3cbf7355f7092fe74e52c0f0bb4f48a
Committed by
Greg Kroah-Hartman
1 parent
9010bb9eaa
Exists in
smarc_8mm_imx_4.14.98_2.0.0_ga
and in
4 other branches
perf parse-events: Fix unchecked usage of strncpy()
[ Upstream commit bd8d57fb7e25e9fcf67a9eef5fa13aabe2016e07 ] The strncpy() function may leave the destination string buffer unterminated, better use strlcpy() that we have a __weak fallback implementation for systems without it. This fixes this warning on an Alpine Linux Edge system with gcc 8.2: util/parse-events.c: In function 'print_symbol_events': util/parse-events.c:2465:4: error: 'strncpy' specified bound 100 equals destination size [-Werror=stringop-truncation] strncpy(name, syms->symbol, MAX_NAME_LEN); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'print_symbol_events.constprop', inlined from 'print_events' at util/parse-events.c:2508:2: util/parse-events.c:2465:4: error: 'strncpy' specified bound 100 equals destination size [-Werror=stringop-truncation] strncpy(name, syms->symbol, MAX_NAME_LEN); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'print_symbol_events.constprop', inlined from 'print_events' at util/parse-events.c:2511:2: util/parse-events.c:2465:4: error: 'strncpy' specified bound 100 equals destination size [-Werror=stringop-truncation] strncpy(name, syms->symbol, MAX_NAME_LEN); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Fixes: 947b4ad1d198 ("perf list: Fix max event string size") Link: https://lkml.kernel.org/n/tip-b663e33bm6x8hrkie4uxh7u2@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
tools/perf/util/parse-events.c
... | ... | @@ -2300,7 +2300,7 @@ |
2300 | 2300 | if (!name_only && strlen(syms->alias)) |
2301 | 2301 | snprintf(name, MAX_NAME_LEN, "%s OR %s", syms->symbol, syms->alias); |
2302 | 2302 | else |
2303 | - strncpy(name, syms->symbol, MAX_NAME_LEN); | |
2303 | + strlcpy(name, syms->symbol, MAX_NAME_LEN); | |
2304 | 2304 | |
2305 | 2305 | evt_list[evt_i] = strdup(name); |
2306 | 2306 | if (evt_list[evt_i] == NULL) |