Eric Lee / smarc-fsl-linux-kernel

Commit 0917798d82212f884fff650e7e520de3b438f947

Authored by Dmitry Adamushko 16 years ago

Committed by Ingo Molnar 16 years ago

Exists in master and in 39 other branches

x86: fix microcode driver newly spewing warnings

Jeff Garzik reported this WARN_ON() noise:

> Kernel: 2.6.30-rc1-00306-g8371f87
> Hardware: ICH10 x86-64
>
> This is a regression from 2.6.29.  Microcode spews the following WARNING
> multiple times during boot:
>
> ------------[ cut here ]------------
> WARNING: at fs/sysfs/group.c:138 sysfs_remove_group+0xeb/0xf0()
> Hardware name:         sysfs group ffffffffa0209700 not found for
>  kobject 'cpu0'

Keep sysfs files around for cpus even when we failed to locate
microcode for them at the moment of module loading. The appropriate
microcode firmware can become available later on.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

Showing 1 changed file with 0 additions and 2 deletions Side-by-side Diff

arch/x86/kernel/microcode_core.c

arch/x86/kernel/microcode_core.c

Diff comments View file @ 0917798

...	...	@@ -391,8 +391,6 @@
391	391	return err;
392	392
393	393	err = microcode_init_cpu(cpu);
394		- if (err)
395		- sysfs_remove_group(&sys_dev->kobj, &mc_attr_group);
396	394
397	395	return err;
398	396	}