Commit 093a44e71aa29157fb1611b00507d67c954099d6

Authored by Julia Lawall
Committed by Linus Torvalds
1 parent cef33400d0

drivers/isdn/sc/ioctl.c: add missing kfree

spid has been allocated in this function and so should be freed before
leaving it, as in the other error handling cases.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

@r exists@
expression E,E1;
statement S;
position p1,p2,p3;
@@

E =@p1 \(kmalloc\|kcalloc\|kzalloc\)(...)
... when != E = E1
if (E == NULL || ...) S
... when != E = E1
if@p2 (...) {
 ... when != kfree(E)
 }
... when != E = E1
kfree@p3(E);

@forall@
position r.p2;
expression r.E;
int E1 != 0;
@@

* if@p2 (...) {
 ... when != kfree(E)
     when strict
return E1; }

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

drivers/isdn/sc/ioctl.c
... ... @@ -226,6 +226,7 @@
226 226 */
227 227 if (copy_from_user(spid, data->dataptr, SCIOC_SPIDSIZE)) {
228 228 kfree(rcvmsg);
  229 + kfree(spid);
229 230 return -EFAULT;
230 231 }
231 232