Commit 0c51a4d8abd6ed5ba55f828840c6b78ab672644b

Authored by Mark Brown
Committed by Matthew Garrett
1 parent a46a780835

platform/x86: Consistently select LEDS Kconfig options

Currently the x86 platform devices are not consistent about selecting
or depending on the LEDs Kconfig variables, and this inconsistency
leads to Kconfig getting upset and refusing to offer LEDs (even on
non-x86 platforms):

drivers/platform/x86/Kconfig:422:error: recursive dependency detected!
drivers/platform/x86/Kconfig:422:       symbol EEEPC_WMI depends on ACPI_WMI
drivers/platform/x86/Kconfig:438:       symbol ACPI_WMI is selected by ACER_WMI
drivers/platform/x86/Kconfig:18:        symbol ACER_WMI depends on LEDS_CLASS
drivers/leds/Kconfig:10:        symbol LEDS_CLASS is selected by EEEPC_WMI

Fix this by always selecting rather than depending on the symbols as
slightly more drivers use this approach already and it seems more
user friendly.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>

Showing 1 changed file with 4 additions and 4 deletions Side-by-side Diff

drivers/platform/x86/Kconfig
... ... @@ -18,8 +18,8 @@
18 18 config ACER_WMI
19 19 tristate "Acer WMI Laptop Extras"
20 20 depends on ACPI
21   - depends on LEDS_CLASS
22   - depends on NEW_LEDS
  21 + select LEDS_CLASS
  22 + select NEW_LEDS
23 23 depends on BACKLIGHT_CLASS_DEVICE
24 24 depends on SERIO_I8042
25 25 depends on INPUT
... ... @@ -516,8 +516,8 @@
516 516 config ACPI_TOSHIBA
517 517 tristate "Toshiba Laptop Extras"
518 518 depends on ACPI
519   - depends on LEDS_CLASS
520   - depends on NEW_LEDS
  519 + select LEDS_CLASS
  520 + select NEW_LEDS
521 521 depends on BACKLIGHT_CLASS_DEVICE
522 522 depends on INPUT
523 523 depends on RFKILL || RFKILL = n