Commit 0cfc11ed45e4c00750039e5a18c0fc0d681e19db

Authored by Carsten Otte
Committed by Linus Torvalds
1 parent 1872bcebbc

[PATCH] fix xip sparse file handling in ext2

Oliver Paukstadt from our test department is testing the xip patches in
Linus' git-tree.  He found a problem that shows when reading a file that
contains sparse blocks (holes) on a -o xip mounted ext2 filesystem: the
BUG_ON() in fs/ext2/xip.c:40 triggers where it should not.  The problem was
introduced by a cleanup in my previous patch, this patch fixes it.

Signed-off-by: Carsten Otte <cotte@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -36,7 +36,7 @@
36 36 *result = tmp.b_blocknr;
37 37  
38 38 /* did we get a sparse block (hole in the file)? */
39   - if (!(*result)) {
  39 + if (!tmp.b_blocknr && !rc) {
40 40 BUG_ON(create);
41 41 rc = -ENODATA;
42 42 }