Commit 1ec22eb2b4a2e1a763106bce36b11c02eaa84e61
1 parent
b8d966efd9
md: fix error path when duplicate name is found on md device creation.
When an md device is created by name (rather than number) we need to check that the name is not already in use. If this check finds a duplicate, we return an error without dropping the lock or freeing the newly create mddev. This patch fixes that. Cc: stable@kernel.org Found-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: NeilBrown <neilb@suse.de>
Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff
drivers/md/md.c
| ... | ... | @@ -3862,6 +3862,8 @@ |
| 3862 | 3862 | if (mddev2->gendisk && |
| 3863 | 3863 | strcmp(mddev2->gendisk->disk_name, name) == 0) { |
| 3864 | 3864 | spin_unlock(&all_mddevs_lock); |
| 3865 | + mutex_unlock(&disks_mutex); | |
| 3866 | + mddev_put(mddev); | |
| 3865 | 3867 | return -EEXIST; |
| 3866 | 3868 | } |
| 3867 | 3869 | spin_unlock(&all_mddevs_lock); |