ASoC: sh: Replace 'select' DMADEVICES 'with depends on'

Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMADEVICES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> Link: https://lore.kernel.org/r/20200731152433.1297-3-laurent.pinchart@ideasonboard.com Signed-off-by: Mark Brown <broonie@kernel.org>

ASoC: sh: Replace 'select' DMADEVICES 'with depends on'
Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMADEVICES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> Link: https://lore.kernel.org/r/20200731152433.1297-3-laurent.pinchart@ideasonboard.com Signed-off-by: Mark Brown <broonie@kernel.org>
Laurent Pinchart · Mark Brown
1 parent 14e5ad7d11
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
sound/soc/sh/Kconfig
@@ -30,8 +30,8 @@
 config SND_SOC_SH4_SIU
 	tristate
 	depends on ARCH_SHMOBILE && HAVE_CLK
+	depends on DMADEVICES
 	select DMA_ENGINE
-	select DMADEVICES
 	select SH_DMAE
 	select FW_LOADER
...	...	@@ -30,8 +30,8 @@
30	30	config SND_SOC_SH4_SIU
31	31	tristate
32	32	depends on ARCH_SHMOBILE && HAVE_CLK
	33	+ depends on DMADEVICES
33	34	select DMA_ENGINE
34		- select DMADEVICES
35	35	select SH_DMAE
36	36	select FW_LOADER
37	37