Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 2f27b81c0e5670fbdd902ca8f85617153d69b8cb

Authored by Rob Herring
Committed by Vinod Koul
1 parent d078cd1b41
Exists in smarc_imx_lf-5.15.y and in 27 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, pitx_8mp_lf-5.10.y, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-n7.1.2_2.0.0-ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y

dmaengine: kill off set_irq_flags usage 

set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Showing 1 changed file with 2 additions and 6 deletions Side-by-side Diff

drivers/dma/ipu/ipu_irq.c
Diff comments   View file @ 2f27b81
... ... @@ -341,9 +341,7 @@
341 341 irq_map[i].irq = irq;
342 342 irq_map[i].source = -EINVAL;
343 343 irq_set_handler(irq, handle_level_irq);
344   -#ifdef CONFIG_ARM
345   - set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
346   -#endif
  344 + irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE);
347 345 }
348 346  
349 347 irq_set_chained_handler_and_data(ipu->irq_fn, ipu_irq_handler, ipu);
... ... @@ -366,9 +364,7 @@
366 364 irq_set_chained_handler_and_data(ipu->irq_err, NULL, NULL);
367 365  
368 366 for (irq = irq_base; irq < irq_base + CONFIG_MX3_IPU_IRQS; irq++) {
369   -#ifdef CONFIG_ARM
370   - set_irq_flags(irq, 0);
371   -#endif
  367 + irq_set_status_flags(irq, IRQ_NOREQUEST);
372 368 irq_set_chip(irq, NULL);
373 369 irq_set_chip_data(irq, NULL);
374 370 }