Commit 2fbe74b90bafebce615466b4c20f96b0465df1ae
Committed by
Takashi Iwai
1 parent
718deb6b61
Exists in
master
and in
39 other branches
sound/oss/pss: Fix test of unsigned in pss_reset_dsp() and pss_download_boot()
limit and jiffies are unsigned so the test did not work. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Showing 1 changed file with 3 additions and 3 deletions Side-by-side Diff
sound/oss/pss.c
... | ... | @@ -269,7 +269,7 @@ |
269 | 269 | unsigned long i, limit = jiffies + HZ/10; |
270 | 270 | |
271 | 271 | outw(0x2000, REG(PSS_CONTROL)); |
272 | - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++) | |
272 | + for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++) | |
273 | 273 | inw(REG(PSS_CONTROL)); |
274 | 274 | outw(0x0000, REG(PSS_CONTROL)); |
275 | 275 | return 1; |
276 | 276 | |
... | ... | @@ -369,11 +369,11 @@ |
369 | 369 | outw(0, REG(PSS_DATA)); |
370 | 370 | |
371 | 371 | limit = jiffies + HZ/10; |
372 | - for (i = 0; i < 32768 && (limit - jiffies >= 0); i++) | |
372 | + for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++) | |
373 | 373 | val = inw(REG(PSS_STATUS)); |
374 | 374 | |
375 | 375 | limit = jiffies + HZ/10; |
376 | - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++) | |
376 | + for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++) | |
377 | 377 | { |
378 | 378 | val = inw(REG(PSS_STATUS)); |
379 | 379 | if (val & 0x4000) |