Commit 34c32fc603311a72cb558e5e337555434f64c27b

Authored by Helge Deller
1 parent 10835c8546

parisc: Ensure userspace privilege for ptraced processes in regset functions

On parisc the privilege level of a process is stored in the lowest two bits of
the instruction pointers (IAOQ0 and IAOQ1). On Linux we use privilege level 0
for the kernel and privilege level 3 for user-space. So userspace should not be
allowed to modify IAOQ0 or IAOQ1 of a ptraced process to change it's privilege
level to e.g. 0 to try to gain kernel privileges.

This patch prevents such modifications in the regset support functions by
always setting the two lowest bits to one (which relates to privilege level 3
for user-space) if IAOQ0 or IAOQ1 are modified via ptrace regset calls.

Link: https://bugs.gentoo.org/481768
Cc: <stable@vger.kernel.org> # v4.7+
Tested-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Signed-off-by: Helge Deller <deller@gmx.de>

Showing 1 changed file with 2 additions and 1 deletions Side-by-side Diff

arch/parisc/kernel/ptrace.c
... ... @@ -504,7 +504,8 @@
504 504 return;
505 505 case RI(iaoq[0]):
506 506 case RI(iaoq[1]):
507   - regs->iaoq[num - RI(iaoq[0])] = val;
  507 + /* set 2 lowest bits to ensure userspace privilege: */
  508 + regs->iaoq[num - RI(iaoq[0])] = val | 3;
508 509 return;
509 510 case RI(sar): regs->sar = val;
510 511 return;