Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 3634634edd49c115da931998b9540bcc17665b05

Authored by Harvey Harrison
Committed by Greg Kroah-Hartman
1 parent c1fe539a7e
Exists in master and in 39 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

debugfs: fix sparse warnings 

extern does not belong in C files, move declaration to linux/debugfs.h
fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static?
fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Showing 2 changed files with 5 additions and 4 deletions Side-by-side Diff

... ... @@ -29,10 +29,6 @@
29 29  
30 30 #define DEBUGFS_MAGIC 0x64626720
31 31  
32   -/* declared over in file.c */
33   -extern struct file_operations debugfs_file_operations;
34   -extern struct inode_operations debugfs_link_operations;
35   -
36 32 static struct vfsmount *debugfs_mount;
37 33 static int debugfs_mount_count;
38 34  
include/linux/debugfs.h
Diff comments   View file @ 3634634
... ... @@ -27,6 +27,11 @@
27 27 };
28 28  
29 29 #if defined(CONFIG_DEBUG_FS)
  30 +
  31 +/* declared over in file.c */
  32 +extern const struct file_operations debugfs_file_operations;
  33 +extern const struct inode_operations debugfs_link_operations;
  34 +
30 35 struct dentry *debugfs_create_file(const char *name, mode_t mode,
31 36 struct dentry *parent, void *data,
32 37 const struct file_operations *fops);