drivers/net/eql.c: prevent reading uninitialized stack memory

Fixed formatting (tabs and line breaks). The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16 bytes of uninitialized stack memory, because the "master_name" member of the master_config_t struct declared on the stack in eql_g_master_cfg() is not altered or zeroed before being copied back to the user. This patch takes care of it. Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/eql.c: prevent reading uninitialized stack memory
Fixed formatting (tabs and line breaks). The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16 bytes of uninitialized stack memory, because the "master_name" member of the master_config_t struct declared on the stack in eql_g_master_cfg() is not altered or zeroed before being copied back to the user. This patch takes care of it. Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Rosenberg · David S. Miller
1 parent 7011e66093
Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff
drivers/net/eql.c
@@ -555,6 +555,8 @@
 	equalizer_t *eql;
 	master_config_t mc;
  
+	memset(&mc, 0, sizeof(master_config_t));
+
 	if (eql_is_master(dev)) {
 		eql = netdev_priv(dev);
 		mc.max_slaves = eql->max_slaves;
...	...	@@ -555,6 +555,8 @@
555	555	equalizer_t *eql;
556	556	master_config_t mc;
557	557
	558	+ memset(&mc, 0, sizeof(master_config_t));
	559	+
558	560	if (eql_is_master(dev)) {
559	561	eql = netdev_priv(dev);
560	562	mc.max_slaves = eql->max_slaves;