Commit 47d24f8c8feee17d9f3e58c4227e3d00d7210120

Authored by Dan Williams
Committed by Greg Kroah-Hartman
1 parent 2c25071bed

mm, devm_memremap_pages: mark devm_memremap_pages() EXPORT_SYMBOL_GPL

commit 808153e1187fa77ac7d7dad261ff476888dcf398 upstream.

devm_memremap_pages() is a facility that can create struct page entries
for any arbitrary range and give drivers the ability to subvert core
aspects of page management.

Specifically the facility is tightly integrated with the kernel's memory
hotplug functionality.  It injects an altmap argument deep into the
architecture specific vmemmap implementation to allow allocating from
specific reserved pages, and it has Linux specific assumptions about page
structure reference counting relative to get_user_pages() and
get_user_pages_fast().  It was an oversight and a mistake that this was
not marked EXPORT_SYMBOL_GPL from the outset.

Again, devm_memremap_pagex() exposes and relies upon core kernel internal
assumptions and will continue to evolve along with 'struct page', memory
hotplug, and support for new memory types / topologies.  Only an in-kernel
GPL-only driver is expected to keep up with this ongoing evolution.  This
interface, and functionality derived from this interface, is not suitable
for kernel-external drivers.

Link: http://lkml.kernel.org/r/154275557457.76910.16923571232582744134.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: "Jérôme Glisse" <jglisse@redhat.com>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Logan Gunthorpe <logang@deltatee.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 2 changed files with 2 additions and 2 deletions Side-by-side Diff

... ... @@ -482,7 +482,7 @@
482 482 devres_free(page_map);
483 483 return ERR_PTR(error);
484 484 }
485   -EXPORT_SYMBOL(devm_memremap_pages);
  485 +EXPORT_SYMBOL_GPL(devm_memremap_pages);
486 486  
487 487 unsigned long vmem_altmap_offset(struct vmem_altmap *altmap)
488 488 {
tools/testing/nvdimm/test/iomap.c
... ... @@ -114,7 +114,7 @@
114 114 return nfit_res->buf + offset - nfit_res->res.start;
115 115 return devm_memremap_pages(dev, res, ref, altmap);
116 116 }
117   -EXPORT_SYMBOL(__wrap_devm_memremap_pages);
  117 +EXPORT_SYMBOL_GPL(__wrap_devm_memremap_pages);
118 118  
119 119 pfn_t __wrap_phys_to_pfn_t(phys_addr_t addr, unsigned long flags)
120 120 {