Commit 49c2fa08a77a7eefa4cbc73601f64984aceacfa7

Authored by Neil Horman
Committed by Jesse Barnes
1 parent 6313e3c217

PCI: Update MCP55 quirk to not affect non HyperTransport variants

I wrote this quirk awhile ago to properly setup MCP55 chips on hypertransport
busses so that interrupts reached whatever cpu happend to boot the kdump kernel.
while that works well, it was recently shown to me that a a non-hypertransport
variant of the MCP55 exists, and on those system the register that this quirk
manipulates causes hangs if you write to it.  Since the quirk was only meant to
handle errors found on MCP55 chips that have a HT interface, this patch adds a
filter to make sure the chip is an HT capable before making the needed register
adjustment.  This lets the broken MCP55s work with kdump while not breaking the
non-HT variants.

Resolves https://bugzilla.kernel.org/show_bug.cgi?id=23952

Tested successfully by the reporter and myself.

Cc: stable@kernel.org
Reported-by: Mathieu Bérard <mathieu@mberard.eu>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Showing 1 changed file with 3 additions and 0 deletions Side-by-side Diff

drivers/pci/quirks.c
... ... @@ -2329,6 +2329,9 @@
2329 2329 {
2330 2330 u32 cfg;
2331 2331  
  2332 + if (!pci_find_capability(dev, PCI_CAP_ID_HT))
  2333 + return;
  2334 +
2332 2335 pci_read_config_dword(dev, 0x74, &cfg);
2333 2336  
2334 2337 if (cfg & ((1 << 2) | (1 << 15))) {