Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 49d2333f97f089ef050fc5b45a40ed88eeabed8e

Authored by Oliver Hartkopp
Committed by Greg Kroah-Hartman
1 parent 4cc2498b7e

slcan: not call free_netdev before rtnl_unlock in slcan_open 

[ Upstream commit 2091a3d42b4f339eaeed11228e0cbe9d4f92f558 ]

As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

This patch is a 1:1 copy of upstream slip.c commit f596c87005f7
("slip: not call free_netdev before rtnl_unlock in slip_open").

Reported-by: yangerkun <yangerkun@huawei.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 3 additions and 0 deletions Side-by-side Diff

drivers/net/can/slcan.c
Diff comments   View file @ 49d2333
... ... @@ -625,7 +625,10 @@
625 625 tty->disc_data = NULL;
626 626 clear_bit(SLF_INUSE, &sl->flags);
627 627 slc_free_netdev(sl->dev);
  628 + /* do not call free_netdev before rtnl_unlock */
  629 + rtnl_unlock();
628 630 free_netdev(sl->dev);
  631 + return err;
629 632  
630 633 err_exit:
631 634 rtnl_unlock();