Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 4c71895830dd66fb9d3331ab27481a777d2a9202

Authored by Marek Lindner
Committed by Antonio Quartulli
1 parent a6cb390940

batman-adv: fix erroneous client entry duplicate detection 

The translation table implementation, namely batadv_compare_tt(),
is used to compare two client entries and deciding if they are the
holding the same information. Each client entry is identified by
its mac address and its VLAN id (VID).
Consequently, batadv_compare_tt() has to not only compare the mac
addresses but also the VIDs.

Without this fix adding a new client entry that possesses the same
mac address as another client but operates on a different VID will
fail because both client entries will considered identical.

Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>

Showing 1 changed file with 4 additions and 2 deletions Side-by-side Diff

net/batman-adv/translation-table.c
Diff comments   View file @ 4c71895
... ... @@ -68,13 +68,15 @@
68 68 unsigned short vid, const char *message,
69 69 bool roaming);
70 70  
71   -/* returns 1 if they are the same mac addr */
  71 +/* returns 1 if they are the same mac addr and vid */
72 72 static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
73 73 {
74 74 const void *data1 = container_of(node, struct batadv_tt_common_entry,
75 75 hash_entry);
  76 + const struct batadv_tt_common_entry *tt1 = data1;
  77 + const struct batadv_tt_common_entry *tt2 = data2;
76 78  
77   - return batadv_compare_eth(data1, data2);
  79 + return (tt1->vid == tt2->vid) && batadv_compare_eth(data1, data2);
78 80 }
79 81  
80 82 /**