Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 4d1566ed2100d074ccc654e5cf2e44cdea3a01d0

Authored by Kay Sievers
Committed by James Bottomley
1 parent c02e600280

[SCSI] fix media change events for polled devices 

Commit:
  a341cd0f (SCSI: add asynchronous event notification API)
breaks:
  285e9670 (sr,sd: send media state change modification events)
by introducing an event filter, which is removed here, to make
events, we are depending on, happen again.

Fix this by removing the event filter.  It's pretty much broken at the
moment, since a user can't set it (the attribute being read only).  A
proper fix will be to make the event discriminator distinguish between
AN and Polled media change events.

Cc: David Zeuthen <david@fubar.dk>
Cc: kristen accardi <kaccardi@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

Showing 1 changed file with 5 additions and 0 deletions Side-by-side Diff

drivers/scsi/scsi_lib.c
Diff comments   View file @ 4d1566e
... ... @@ -2162,10 +2162,15 @@
2162 2162 {
2163 2163 unsigned long flags;
2164 2164  
  2165 +#if 0
  2166 + /* FIXME: currently this check eliminates all media change events
  2167 + * for polled devices. Need to update to discriminate between AN
  2168 + * and polled events */
2165 2169 if (!test_bit(evt->evt_type, sdev->supported_events)) {
2166 2170 kfree(evt);
2167 2171 return;
2168 2172 }
  2173 +#endif
2169 2174  
2170 2175 spin_lock_irqsave(&sdev->list_lock, flags);
2171 2176 list_add_tail(&evt->node, &sdev->event_list);