Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code »

Commit 5477fccf9abd7342a987d401fa50c0d93ebd09b9

Authored by Markus Elfring
Committed by David S. Miller
1 parent b7deac3197

net: usb: Delete unnecessary checks before the macro call “dev_kfree_skb” 

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 2 changed files with 3 additions and 7 deletions Side-by-side Diff

drivers/net/usb/lg-vl600.c
Diff comments   View file @ 5477fcc
... ... @@ -87,9 +87,7 @@
87 87 {
88 88 struct vl600_state *s = dev->driver_priv;
89 89  
90   - if (s->current_rx_buf)
91   - dev_kfree_skb(s->current_rx_buf);
92   -
  90 + dev_kfree_skb(s->current_rx_buf);
93 91 kfree(s);
94 92  
95 93 return usbnet_cdc_unbind(dev, intf);
drivers/net/usb/rtl8150.c
Diff comments   View file @ 5477fcc
... ... @@ -586,8 +586,7 @@
586 586 int i;
587 587  
588 588 for (i = 0; i < RX_SKB_POOL_SIZE; i++)
589   - if (dev->rx_skb_pool[i])
590   - dev_kfree_skb(dev->rx_skb_pool[i]);
  589 + dev_kfree_skb(dev->rx_skb_pool[i]);
591 590 }
592 591  
593 592 static void rx_fixup(unsigned long data)
... ... @@ -946,8 +945,7 @@
946 945 unlink_all_urbs(dev);
947 946 free_all_urbs(dev);
948 947 free_skb_pool(dev);
949   - if (dev->rx_skb)
950   - dev_kfree_skb(dev->rx_skb);
  948 + dev_kfree_skb(dev->rx_skb);
951 949 kfree(dev->intr_buff);
952 950 free_netdev(dev->netdev);
953 951 }