Eric Lee / smarc-fsl-linux-kernel

1
Download as
Browse Code »

Commit 58b48576966ed0afd3f63ef17480ec12748a7119

Authored by Andrew Vasquez
Committed by James Bottomley
1 parent 3553d343e7
Exists in master and in 38 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

[SCSI] qla2xxx: Correct inadvertent loop state transitions during port-update handling. 

Transitioning to a LOOP_UPDATE loop-state could cause the driver
to miss normal link/target processing.  LOOP_UPDATE is a crufty
artifact leftover from at time the driver performed it's own
internal command-queuing.  Safely remove this state.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

Showing 2 changed files with 0 additions and 4 deletions Side-by-side Diff

drivers/scsi/qla2xxx/qla_init.c
Diff comments   View file @ 58b4857
... ... @@ -3838,15 +3838,12 @@
3838 3838 req = vha->req;
3839 3839 rsp = req->rsp;
3840 3840  
3841   - atomic_set(&vha->loop_state, LOOP_UPDATE);
3842 3841 clear_bit(ISP_ABORT_RETRY, &vha->dpc_flags);
3843 3842 if (vha->flags.online) {
3844 3843 if (!(rval = qla2x00_fw_ready(vha))) {
3845 3844 /* Wait at most MAX_TARGET RSCNs for a stable link. */
3846 3845 wait_time = 256;
3847 3846 do {
3848   - atomic_set(&vha->loop_state, LOOP_UPDATE);
3849   -
3850 3847 /* Issue a marker after FW becomes ready. */
3851 3848 qla2x00_marker(vha, req, rsp, 0, 0,
3852 3849 MK_SYNC_ALL);
drivers/scsi/qla2xxx/qla_isr.c
Diff comments   View file @ 58b4857
... ... @@ -719,7 +719,6 @@
719 719 vha->flags.rscn_queue_overflow = 1;
720 720 }
721 721  
722   - atomic_set(&vha->loop_state, LOOP_UPDATE);
723 722 atomic_set(&vha->loop_down_timer, 0);
724 723 vha->flags.management_server_logged_in = 0;
725 724