lib/parser: cleanup match_number()

Use new variable 'len' to make code more readable. Signed-off-by: Namhyung Kim <namhyung@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

lib/parser: cleanup match_number()
Use new variable 'len' to make code more readable. Signed-off-by: Namhyung Kim <namhyung@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Namhyung Kim · Linus Torvalds
1 parent ea00c30b5b
Showing 1 changed file with 4 additions and 3 deletions Side-by-side Diff
lib/parser.c
@@ -128,12 +128,13 @@
 	char *endp;
 	char *buf;
 	int ret;
+	size_t len = s->to - s->from;
  
-	buf = kmalloc(s->to - s->from + 1, GFP_KERNEL);
+	buf = kmalloc(len + 1, GFP_KERNEL);
 	if (!buf)
 		return -ENOMEM;
-	memcpy(buf, s->from, s->to - s->from);
-	buf[s->to - s->from] = '\0';
+	memcpy(buf, s->from, len);
+	buf[len] = '\0';
 	*result = simple_strtol(buf, &endp, base);
 	ret = 0;
 	if (endp == buf)
...	...	@@ -128,12 +128,13 @@
128	128	char *endp;
129	129	char *buf;
130	130	int ret;
	131	+ size_t len = s->to - s->from;
131	132
132		- buf = kmalloc(s->to - s->from + 1, GFP_KERNEL);
	133	+ buf = kmalloc(len + 1, GFP_KERNEL);
133	134	if (!buf)
134	135	return -ENOMEM;
135		- memcpy(buf, s->from, s->to - s->from);
136		- buf[s->to - s->from] = '\0';
	136	+ memcpy(buf, s->from, len);
	137	+ buf[len] = '\0';
137	138	*result = simple_strtol(buf, &endp, base);
138	139	ret = 0;
139	140	if (endp == buf)