Commit 6884b348ed759184032306c9435a727741a72298

Authored by Joe Perches
Committed by David S. Miller
1 parent 650b2ef5d7

net/rds: remove uses of NIPQUAD, use %pI4

Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Grover <andy.grover@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 3 changed files with 8 additions and 9 deletions Side-by-side Diff

net/rds/tcp_connect.c
... ... @@ -90,8 +90,8 @@
90 90  
91 91 ret = sock->ops->bind(sock, (struct sockaddr *)&src, sizeof(src));
92 92 if (ret) {
93   - rdsdebug("bind failed with %d at address %u.%u.%u.%u\n",
94   - ret, NIPQUAD(conn->c_laddr));
  93 + rdsdebug("bind failed with %d at address %pI4\n",
  94 + ret, &conn->c_laddr);
95 95 goto out;
96 96 }
97 97  
... ... @@ -108,8 +108,7 @@
108 108 O_NONBLOCK);
109 109 sock = NULL;
110 110  
111   - rdsdebug("connect to address %u.%u.%u.%u returned %d\n",
112   - NIPQUAD(conn->c_faddr), ret);
  111 + rdsdebug("connect to address %pI4 returned %d\n", &conn->c_faddr, ret);
113 112 if (ret == -EINPROGRESS)
114 113 ret = 0;
115 114  
net/rds/tcp_listen.c
... ... @@ -66,9 +66,9 @@
66 66  
67 67 inet = inet_sk(new_sock->sk);
68 68  
69   - rdsdebug("accepted tcp %u.%u.%u.%u:%u -> %u.%u.%u.%u:%u\n",
70   - NIPQUAD(inet->inet_saddr), ntohs(inet->inet_sport),
71   - NIPQUAD(inet->inet_daddr), ntohs(inet->inet_dport));
  69 + rdsdebug("accepted tcp %pI4:%u -> %pI4:%u\n",
  70 + &inet->inet_saddr, ntohs(inet->inet_sport),
  71 + &inet->inet_daddr, ntohs(inet->inet_dport));
72 72  
73 73 conn = rds_conn_create(inet->inet_saddr, inet->inet_daddr,
74 74 &rds_tcp_transport, GFP_KERNEL);
... ... @@ -193,9 +193,9 @@
193 193 rds_tcp_stats_inc(s_tcp_sndbuf_full);
194 194 ret = 0;
195 195 } else {
196   - printk(KERN_WARNING "RDS/tcp: send to %u.%u.%u.%u "
  196 + printk(KERN_WARNING "RDS/tcp: send to %pI4 "
197 197 "returned %d, disconnecting and reconnecting\n",
198   - NIPQUAD(conn->c_faddr), ret);
  198 + &conn->c_faddr, ret);
199 199 rds_conn_drop(conn);
200 200 }
201 201 }