Commit 6fd4777a1fec1f7757b5a302ad3fdcc1eae2abba
1 parent
239795adf7
Exists in
master
and in
39 other branches
Revert "rose: zero length frame filtering in af_rose.c"
This reverts commit 244f46ae6e9e18f6fc0be7d1f49febde4762c34b. Alan Cox did the research, and just like the other radio protocols zero-length frames have meaning because at the top level ROSE is X.25 PLP. So this zero-length filtering is invalid. Signed-off-by: David S. Miller <davem@davemloft.net>
Showing 1 changed file with 0 additions and 10 deletions Side-by-side Diff
net/rose/af_rose.c
| ... | ... | @@ -1072,10 +1072,6 @@ |
| 1072 | 1072 | unsigned char *asmptr; |
| 1073 | 1073 | int n, size, qbit = 0; |
| 1074 | 1074 | |
| 1075 | - /* ROSE empty frame has no meaning : don't send */ | |
| 1076 | - if (len == 0) | |
| 1077 | - return 0; | |
| 1078 | - | |
| 1079 | 1075 | if (msg->msg_flags & ~(MSG_DONTWAIT|MSG_EOR|MSG_CMSG_COMPAT)) |
| 1080 | 1076 | return -EINVAL; |
| 1081 | 1077 | |
| ... | ... | @@ -1272,12 +1268,6 @@ |
| 1272 | 1268 | |
| 1273 | 1269 | skb_reset_transport_header(skb); |
| 1274 | 1270 | copied = skb->len; |
| 1275 | - | |
| 1276 | - /* ROSE empty frame has no meaning : ignore it */ | |
| 1277 | - if (copied == 0) { | |
| 1278 | - skb_free_datagram(sk, skb); | |
| 1279 | - return copied; | |
| 1280 | - } | |
| 1281 | 1271 | |
| 1282 | 1272 | if (copied > size) { |
| 1283 | 1273 | copied = size; |