Commit 7f81c8890c15a10f5220bebae3b6dfae4961962a
Committed by
Linus Torvalds
1 parent
b0825ee3a8
Exists in
master
and in
39 other branches
fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP
Commit a8bef8ff6ea1 ("mm: migration: avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks") introduced a BUG_ON() to ensure that VM_STACK_FLAGS and VM_STACK_INCOMPLETE_SETUP do not overlap. The check is a compile time one, so BUILD_BUG_ON is more appropriate. Signed-off-by: Michal Hocko <mhocko@suse.cz> Cc: Mel Gorman <mel@csn.ul.ie> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
fs/exec.c
... | ... | @@ -277,7 +277,7 @@ |
277 | 277 | * use STACK_TOP because that can depend on attributes which aren't |
278 | 278 | * configured yet. |
279 | 279 | */ |
280 | - BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP); | |
280 | + BUILD_BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP); | |
281 | 281 | vma->vm_end = STACK_TOP_MAX; |
282 | 282 | vma->vm_start = vma->vm_end - PAGE_SIZE; |
283 | 283 | vma->vm_flags = VM_STACK_FLAGS | VM_STACK_INCOMPLETE_SETUP; |