Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 8d99513c1b76cfd0b2dcf061c5136cb1061e6b37

Authored by Michal Marek
Committed by Rusty Russell
1 parent d4703aefdb
Exists in master and in 39 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

modpost: fix segfault with short symbol names 

memcmp() is wrong here, the symbol name can be shorter than KSYMTAB_PFX
or CRC_PFX.

Signed-off-by: Michal Marek <mmarek@suse.cz>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

scripts/mod/modpost.c
Diff comments   View file @ 8d99513
... ... @@ -522,7 +522,7 @@
522 522 break;
523 523 case SHN_ABS:
524 524 /* CRC'd symbol */
525   - if (memcmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) {
  525 + if (strncmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) {
526 526 crc = (unsigned int) sym->st_value;
527 527 sym_update_crc(symname + strlen(CRC_PFX), mod, crc,
528 528 export);
... ... @@ -566,7 +566,7 @@
566 566 break;
567 567 default:
568 568 /* All exported symbols */
569   - if (memcmp(symname, KSYMTAB_PFX, strlen(KSYMTAB_PFX)) == 0) {
  569 + if (strncmp(symname, KSYMTAB_PFX, strlen(KSYMTAB_PFX)) == 0) {
570 570 sym_add_exported(symname + strlen(KSYMTAB_PFX), mod,
571 571 export);
572 572 }