Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 8ee031631546cf2f7859cc69593bd60bbdd70b46

Authored by Tuomas Tynkkynen
Committed by Al Viro
1 parent 357fdad075

fs/9p: Compare qid.path in v9fs_test_inode 

Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details
and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked()
instead of iget_locked(). However, the test() callback is not checking
fid.path at all, which means that a lookup in the inode cache can now
accidentally locate a completely wrong inode from the same inode hash
bucket if the other fields (qid.type and qid.version) match.

Fixes: fd2421f54423 ("fs/9p: When doing inode lookup compare qid details and inode mode bits.")
Cc: stable@vger.kernel.org
Reviewed-by: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Showing 2 changed files with 6 additions and 0 deletions Side-by-side Diff

... ... @@ -483,6 +483,9 @@
483 483  
484 484 if (v9inode->qid.type != st->qid.type)
485 485 return 0;
  486 +
  487 + if (v9inode->qid.path != st->qid.path)
  488 + return 0;
486 489 return 1;
487 490 }
488 491  
fs/9p/vfs_inode_dotl.c
Diff comments   View file @ 8ee0316
... ... @@ -87,6 +87,9 @@
87 87  
88 88 if (v9inode->qid.type != st->qid.type)
89 89 return 0;
  90 +
  91 + if (v9inode->qid.path != st->qid.path)
  92 + return 0;
90 93 return 1;
91 94 }
92 95