Commit 8fc62e59425389a6d48429b9d146223122743435
1 parent
569658dddf
Exists in
master
and in
39 other branches
kbuild: Do not write to builddir in modules_install
Let depmod.sh create a temporary directory in /tmp instead of writing to the build directory as root. The mktemp utility should be available on any recent system (and there is already scripts/gen_initramfs_list.sh relying on it). Reported-by: Christian Kujau <lists@nerdbynature.de> Signed-off-by: Michal Marek <mmarek@suse.cz>
Showing 1 changed file with 6 additions and 4 deletions Side-by-side Diff
scripts/depmod.sh
| ... | ... | @@ -21,13 +21,15 @@ |
| 21 | 21 | # older versions of depmod require the version string to start with three |
| 22 | 22 | # numbers, so we cheat with a symlink here |
| 23 | 23 | depmod_hack_needed=true |
| 24 | -mkdir -p .tmp_depmod/lib/modules/$KERNELRELEASE | |
| 25 | -if "$DEPMOD" -b .tmp_depmod $KERNELRELEASE 2>/dev/null; then | |
| 26 | - if test -e .tmp_depmod/lib/modules/$KERNELRELEASE/modules.dep -o \ | |
| 27 | - -e .tmp_depmod/lib/modules/$KERNELRELEASE/modules.dep.bin; then | |
| 24 | +tmp_dir=$(mktemp -d ${TMPDIR:-/tmp}/depmod.XXXXXX) | |
| 25 | +mkdir -p "$tmp_dir/lib/modules/$KERNELRELEASE" | |
| 26 | +if "$DEPMOD" -b "$tmp_dir" $KERNELRELEASE 2>/dev/null; then | |
| 27 | + if test -e "$tmp_dir/lib/modules/$KERNELRELEASE/modules.dep" -o \ | |
| 28 | + -e "$tmp_dir/lib/modules/$KERNELRELEASE/modules.dep.bin"; then | |
| 28 | 29 | depmod_hack_needed=false |
| 29 | 30 | fi |
| 30 | 31 | fi |
| 32 | +rm -rf "$tmp_dir" | |
| 31 | 33 | if $depmod_hack_needed; then |
| 32 | 34 | symlink="$INSTALL_MOD_PATH/lib/modules/99.98.$KERNELRELEASE" |
| 33 | 35 | ln -s "$KERNELRELEASE" "$symlink" |