vfs: get_sb_single() - do not pass options twice

Filesystem code usually destroys the option buffer while parsing it. This leads to errors when the same buffer is passed twice. In case we fill a new superblock do not call remount. This is needed to quite a warning that the debugfs code causes every boot. Cc: Miklos Szeredi <miklos@szeredi.hu> Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

vfs: get_sb_single() - do not pass options twice
Filesystem code usually destroys the option buffer while parsing it. This leads to errors when the same buffer is passed twice. In case we fill a new superblock do not call remount. This is needed to quite a warning that the debugfs code causes every boot. Cc: Miklos Szeredi <miklos@szeredi.hu> Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Kay Sievers · Greg Kroah-Hartman
1 parent f1f76f865b
Showing 1 changed file with 2 additions and 1 deletions Side-by-side Diff
fs/super.c
@@ -901,8 +901,9 @@
 			return error;
 		}
 		s->s_flags |= MS_ACTIVE;
+	} else {
+		do_remount_sb(s, flags, data, 0);
 	}
-	do_remount_sb(s, flags, data, 0);
 	simple_set_mnt(mnt, s);
 	return 0;
 }
...	...	@@ -901,8 +901,9 @@
901	901	return error;
902	902	}
903	903	s->s_flags \|= MS_ACTIVE;
	904	+ } else {
	905	+ do_remount_sb(s, flags, data, 0);
904	906	}
905		- do_remount_sb(s, flags, data, 0);
906	907	simple_set_mnt(mnt, s);
907	908	return 0;
908	909	}