netfilter: ctnetlink: put back references to master ct and expect objects

We have to put back the references to the master conntrack and the expectation that we just created, otherwise we'll leak them. Fixes: 0ef71ee1a5b9 ("netfilter: ctnetlink: refactor ctnetlink_create_expect") Reported-by: Tim Wiess <Tim.Wiess@watchguard.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

netfilter: ctnetlink: put back references to master ct and expect objects
We have to put back the references to the master conntrack and the expectation that we just created, otherwise we'll leak them. Fixes: 0ef71ee1a5b9 ("netfilter: ctnetlink: refactor ctnetlink_create_expect") Reported-by: Tim Wiess <Tim.Wiess@watchguard.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Pablo Neira Ayuso
1 parent a7d35f9d73
Showing 1 changed file with 0 additions and 5 deletions Side-by-side Diff
net/netfilter/nf_conntrack_netlink.c
@@ -2995,11 +2995,6 @@
 	}
  
 	err = nf_ct_expect_related_report(exp, portid, report);
-	if (err < 0)
-		goto err_exp;
-
-	return 0;
-err_exp:
 	nf_ct_expect_put(exp);
 err_ct:
 	nf_ct_put(ct);
...	...	@@ -2995,11 +2995,6 @@
2995	2995	}
2996	2996
2997	2997	err = nf_ct_expect_related_report(exp, portid, report);
2998		- if (err < 0)
2999		- goto err_exp;
3000		-
3001		- return 0;
3002		-err_exp:
3003	2998	nf_ct_expect_put(exp);
3004	2999	err_ct:
3005	3000	nf_ct_put(ct);