Commit 9c95e7319ba98585ebb6d304eca2d56f401ed70c
Committed by
Ingo Molnar
1 parent
1799e35d5b
Exists in
master
and in
39 other branches
sched: fix invalid sched_class use
When using rt_mutex, a NULL pointer dereference is occurred at enqueue_task_rt. Here is a scenario; 1) there are two threads, the thread A is fair_sched_class and thread B is rt_sched_class. 2) Thread A is boosted up to rt_sched_class, because the thread A has a rt_mutex lock and the thread B is waiting the lock. 3) At this time, when thread A create a new thread C, the thread C has a rt_sched_class. 4) When doing wake_up_new_task() for the thread C, the priority of the thread C is out of the RT priority range, because the normal priority of thread A is not the RT priority. It makes data corruption by overflowing the rt_prio_array. The new thread C should be fair_sched_class. The new thread should be valid scheduler class before queuing. This patch fixes to set the suitable scheduler class. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Showing 1 changed file with 5 additions and 0 deletions Side-by-side Diff
kernel/sched.c
... | ... | @@ -1682,6 +1682,11 @@ |
1682 | 1682 | |
1683 | 1683 | p->prio = effective_prio(p); |
1684 | 1684 | |
1685 | + if (rt_prio(p->prio)) | |
1686 | + p->sched_class = &rt_sched_class; | |
1687 | + else | |
1688 | + p->sched_class = &fair_sched_class; | |
1689 | + | |
1685 | 1690 | if (!p->sched_class->task_new || !sysctl_sched_child_runs_first || |
1686 | 1691 | (clone_flags & CLONE_VM) || task_cpu(p) != this_cpu || |
1687 | 1692 | !current->se.on_rq) { |