Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit a5ca3a1bc719cb9056acc6f24340a1e2674f21a0

Authored by Jiri Slaby
Committed by Mauro Carvalho Chehab
1 parent 11b79ea75a

V4L/DVB (12203): radio-si470x: fix lock imbalance 

There is one path with omitted unlock in si470x_fops_release. Fix that.

Cc: Tobias Lorenz <tobias.lorenz@gmx.net>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Showing 1 changed file with 2 additions and 3 deletions Side-by-side Diff

drivers/media/radio/radio-si470x.c
Diff comments   View file @ a5ca3a1
... ... @@ -1200,7 +1200,7 @@
1200 1200 video_unregister_device(radio->videodev);
1201 1201 kfree(radio->buffer);
1202 1202 kfree(radio);
1203   - goto done;
  1203 + goto unlock;
1204 1204 }
1205 1205  
1206 1206 /* stop rds reception */
1207 1207  
... ... @@ -1213,9 +1213,8 @@
1213 1213 retval = si470x_stop(radio);
1214 1214 usb_autopm_put_interface(radio->intf);
1215 1215 }
1216   -
  1216 +unlock:
1217 1217 mutex_unlock(&radio->disconnect_lock);
1218   -
1219 1218 done:
1220 1219 return retval;
1221 1220 }