Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit a6de51b2787012ba3ab62c7d50df1b749b83d5f0

Authored by Rusty Russell
1 parent 4ef2db016a
Exists in master and in 39 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

param: don't deref arg in __same_type() checks 

gcc allows this when arg is a function, but sparse complains:

drivers/char/ipmi/ipmi_watchdog.c:303:1: error: cannot dereference this type
drivers/char/ipmi/ipmi_watchdog.c:307:1: error: cannot dereference this type
drivers/char/ipmi/ipmi_watchdog.c:311:1: error: cannot dereference this type

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Tested-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Showing 1 changed file with 5 additions and 5 deletions Side-by-side Diff

include/linux/moduleparam.h
Diff comments   View file @ a6de51b
... ... @@ -125,7 +125,7 @@
125 125 */
126 126 #define module_param_cb(name, ops, arg, perm) \
127 127 __module_param_call(MODULE_PARAM_PREFIX, \
128   - name, ops, arg, __same_type(*(arg), bool), perm)
  128 + name, ops, arg, __same_type((arg), bool *), perm)
129 129  
130 130 /* On alpha, ia64 and ppc64 relocations to global data cannot go into
131 131 read-only sections (which is part of respective UNIX ABI on these
... ... @@ -157,7 +157,7 @@
157 157 { (void *)set, (void *)get }; \
158 158 __module_param_call(MODULE_PARAM_PREFIX, \
159 159 name, &__param_ops_##name, arg, \
160   - __same_type(*(arg), bool), \
  160 + __same_type(arg, bool *), \
161 161 (perm) + sizeof(__check_old_set_param(set))*0)
162 162  
163 163 /* We don't get oldget: it's often a new-style param_get_uint, etc. */
... ... @@ -330,9 +330,9 @@
330 330 #define param_check_bool(name, p) \
331 331 static inline void __check_##name(void) \
332 332 { \
333   - BUILD_BUG_ON(!__same_type(*(p), bool) && \
334   - !__same_type(*(p), unsigned int) && \
335   - !__same_type(*(p), int)); \
  333 + BUILD_BUG_ON(!__same_type((p), bool *) && \
  334 + !__same_type((p), unsigned int *) && \
  335 + !__same_type((p), int *)); \
336 336 }
337 337  
338 338 extern struct kernel_param_ops param_ops_invbool;