Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit adb4b83c12f9d966ea3478aa14c60511467c9916

Authored by Dan Carpenter
Committed by Jason Wessel
1 parent 521cb40b0c
Exists in master and in 39 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

kgdboc,kgdbts: strlen() doesn't count the terminator 

This is an off by one because strlen() doesn't count the null
terminator.  We strcpy() these strings into an array of size
MAX_CONFIG_LEN.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

Showing 2 changed files with 2 additions and 2 deletions Side-by-side Diff

drivers/misc/kgdbts.c
Diff comments   View file @ adb4b83
... ... @@ -988,7 +988,7 @@
988 988  
989 989 static int kgdbts_option_setup(char *opt)
990 990 {
991   - if (strlen(opt) > MAX_CONFIG_LEN) {
  991 + if (strlen(opt) >= MAX_CONFIG_LEN) {
992 992 printk(KERN_ERR "kgdbts: config string too long\n");
993 993 return -ENOSPC;
994 994 }
drivers/tty/serial/kgdboc.c
Diff comments   View file @ adb4b83
... ... @@ -131,7 +131,7 @@
131 131  
132 132 static int kgdboc_option_setup(char *opt)
133 133 {
134   - if (strlen(opt) > MAX_CONFIG_LEN) {
  134 + if (strlen(opt) >= MAX_CONFIG_LEN) {
135 135 printk(KERN_ERR "kgdboc: config string too long\n");
136 136 return -ENOSPC;
137 137 }