Commit ae970eb45d8a1ea4506be23c3f776225b9575d0e
Committed by
Takashi Iwai
1 parent
4d8ce1c996
ALSA: sound/pci/sis7019.c: fix error return code
Initialize rc before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Showing 1 changed file with 3 additions and 2 deletions Side-by-side Diff
sound/pci/sis7019.c
... | ... | @@ -1377,8 +1377,9 @@ |
1377 | 1377 | if (rc) |
1378 | 1378 | goto error_out_cleanup; |
1379 | 1379 | |
1380 | - if (request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, | |
1381 | - sis)) { | |
1380 | + rc = request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, | |
1381 | + sis); | |
1382 | + if (rc) { | |
1382 | 1383 | dev_err(&pci->dev, "unable to allocate irq %d\n", sis->irq); |
1383 | 1384 | goto error_out_cleanup; |
1384 | 1385 | } |