Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit b714295abc59cfa2fe46f9341503d9a7eb790503

Authored by Jon Maloy
Committed by David S. Miller
1 parent f51ffde927

tipc: Fix missing list initializations in struct tipc_subscription 

When an item of struct tipc_subscription is created, we fail to
initialize the two lists aggregated into the struct. This has so far
never been a problem, since the items are just added to a root
object by list_add(), which does not require the addee list to be
pre-initialized. However, syzbot is provoking situations where this
addition fails, whereupon the attempted removal if the item from
the list causes a crash.

This problem seems to always have been around, despite that the code
for creating this object was rewritten in commit 242e82cc95f6 ("tipc:
collapse subscription creation functions"), which is still in net-next.

We fix this for that commit by initializing the two lists properly.

Fixes: 242e82cc95f6 ("tipc: collapse subscription creation functions")
Reported-by: syzbot+0bb443b74ce09197e970@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

... ... @@ -145,6 +145,8 @@
145 145 pr_warn("Subscription rejected, no memory\n");
146 146 return NULL;
147 147 }
  148 + INIT_LIST_HEAD(&sub->service_list);
  149 + INIT_LIST_HEAD(&sub->sub_list);
148 150 sub->net = net;
149 151 sub->conid = conid;
150 152 sub->inactive = false;