Eric Lee / smarc-fsl-linux-kernel

Commit c095adbc211f9f4e990eac7d6cb440de35e4f05f

Authored by KOSAKI Motohiro 16 years ago

Committed by Linus Torvalds 16 years ago

Exists in master and in 39 other branches

mm: Don't touch uninitialized variable in do_pages_stat_array()

Commit 80bba1290ab5122c60cdb73332b26d288dc8aedd removed one necessary
variable initialization.  As a result following warning happened:

    CC      mm/migrate.o
  mm/migrate.c: In function 'sys_move_pages':
  mm/migrate.c:1001: warning: 'err' may be used uninitialized in this function

More unfortunately, if find_vma() failed, kernel read uninitialized
memory.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Brice Goglin <Brice.Goglin@inria.fr>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

mm/migrate.c

mm/migrate.c

Diff comments View file @ c095adb

...	...	@@ -998,7 +998,7 @@
998	998	unsigned long addr = (unsigned long)(*pages);
999	999	struct vm_area_struct *vma;
1000	1000	struct page *page;
1001		- int err;
	1001	+ int err = -EFAULT;
1002	1002
1003	1003	vma = find_vma(mm, addr);
1004	1004	if (!vma)