Commit c4ade94fc00f8b34589719d8a347f658b6d3951e
Committed by
Jens Axboe
Jens Axboe
1 parent
62a37f6bad
Exists in
master
and in
39 other branches
cfq-iosched: removing unnecessary think time checking
Removing think time checking. A high thinktime queue might means the queue dispatches several requests and then do away. Limitting such queue seems meaningless. And also this can simplify code. This is suggested by Vivek. Signed-off-by: Shaohua Li <shaohua.li@intel.com> Acked-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Showing 1 changed file with 4 additions and 9 deletions Side-by-side Diff
block/cfq-iosched.c
| ... | ... | @@ -2417,19 +2417,14 @@ |
| 2417 | 2417 | return false; |
| 2418 | 2418 | |
| 2419 | 2419 | /* |
| 2420 | - * If there is only one sync queue, and its think time is | |
| 2421 | - * small, we can ignore async queue here and give the sync | |
| 2420 | + * If there is only one sync queue | |
| 2421 | + * we can ignore async queue here and give the sync | |
| 2422 | 2422 | * queue no dispatch limit. The reason is a sync queue can |
| 2423 | 2423 | * preempt async queue, limiting the sync queue doesn't make |
| 2424 | 2424 | * sense. This is useful for aiostress test. |
| 2425 | 2425 | */ |
| 2426 | - if (cfq_cfqq_sync(cfqq) && cfqd->busy_sync_queues == 1) { | |
| 2427 | - struct cfq_io_context *cic = RQ_CIC(cfqq->next_rq); | |
| 2428 | - | |
| 2429 | - if (sample_valid(cic->ttime_samples) && | |
| 2430 | - cic->ttime_mean < cfqd->cfq_slice_idle) | |
| 2431 | - promote_sync = true; | |
| 2432 | - } | |
| 2426 | + if (cfq_cfqq_sync(cfqq) && cfqd->busy_sync_queues == 1) | |
| 2427 | + promote_sync = true; | |
| 2433 | 2428 | |
| 2434 | 2429 | /* |
| 2435 | 2430 | * We have other queues, don't allow more IO from this one |