Commit c61e2fc87f24cae4701f352fe9ecd4c5c143106c

Authored by Miaoqian Lin
Committed by Greg Kroah-Hartman
1 parent ba81399402

coresight: syscfg: Fix memleak on registration failure in cscfg_create_device

commit cfa5dbcdd7aece76f3415284569f2f384aff0253 upstream.

device_register() calls device_initialize(),
according to doc of device_initialize:

    Use put_device() to give up your reference instead of freeing
    * @dev directly once you have called this function.

To prevent potential memleak, use put_device() for error handling.

Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220124124121.8888-1-linmq006@gmail.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/hwtracing/coresight/coresight-syscfg.c
... ... @@ -791,7 +791,7 @@
791 791  
792 792 err = device_register(dev);
793 793 if (err)
794   - cscfg_dev_release(dev);
  794 + put_device(dev);
795 795  
796 796 create_dev_exit_unlock:
797 797 mutex_unlock(&cscfg_mutex);